Skip to content

Replay::Role::BusinessRule has some unused attributes #13

@byterock

Description

@byterock

package Replay::Role::BusinessRule;

use Moose::Role;
use Moose::Util::TypeConstraints;

our $VERSION = '0.02';

has eventSystem => ( is => 'ro', isa => 'Replay::EventSystem', );
has reportEngine => ( is => 'ro', isa => 'Str', );

When I was diging agout trying to fix something I noticed that Rules that are being used will never have the eventSystem or the reportEngine set at any time

With replayd for example all the rules are 'invoked' loaded into an array then sent to the replay->ruleSource
but at no time is an eventSystem passed to the rules

So as the is a ro var and can only be set at create via a named patam (ie new) they will never be set

is there some reason for each rule has an event system?

Perhaps we can set this to RW then set it when the rules are added if it needs to be there??

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions