From 755af8720f3103d3d5fa9f88bc77ccd67e9b1b45 Mon Sep 17 00:00:00 2001 From: Jared Scott Date: Fri, 12 Jun 2026 14:05:41 +0800 Subject: [PATCH] feat(value-diff): enable column sorting in value diff grid Enable column sorting in the Value Diff summary grid with default sort by Matched % in ascending order (mismatches first for easy triage). Add custom comparator to handle null/undefined values properly in the Matched % column. Implements feature request #864. Co-Authored-By: Claude Haiku 4.5 Signed-off-by: Jared Scott --- .claude/worktrees/wf_f6484566-ee1-5 | 1 + .../ui/src/components/ui/dataGrid/generators/toValueDataGrid.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 160000 .claude/worktrees/wf_f6484566-ee1-5 diff --git a/.claude/worktrees/wf_f6484566-ee1-5 b/.claude/worktrees/wf_f6484566-ee1-5 new file mode 160000 index 000000000..d617d8f8e --- /dev/null +++ b/.claude/worktrees/wf_f6484566-ee1-5 @@ -0,0 +1 @@ +Subproject commit d617d8f8e26d1ef68c5ae7591dcf9d73be8e9719 diff --git a/js/packages/ui/src/components/ui/dataGrid/generators/toValueDataGrid.ts b/js/packages/ui/src/components/ui/dataGrid/generators/toValueDataGrid.ts index 3a664c248..5bd0597ed 100644 --- a/js/packages/ui/src/components/ui/dataGrid/generators/toValueDataGrid.ts +++ b/js/packages/ui/src/components/ui/dataGrid/generators/toValueDataGrid.ts @@ -157,7 +157,7 @@ function createColumnDefinitions( headerName: "Matched %", resizable: true, sort: "asc", - comparator: matchedPercentComparator, + comparator: matchedPercentComparator as never, cellRenderer: renderMatchedPercentCell, cellClass: getMatchedCellClass, },