Skip to content

feedback from Danyel #5

@danyelf

Description

@danyelf

I created a config that already had a main and a dev, assuming that I'm simulating someone who already has a dbt CI set up. I also had a venv with python3.12 (to be dbt compatible) and did not have any files checked out.

It worked! It was easy! It was quick!

MOST IMPORTANT

I would love to sequence this work so that it takes care of ALL interactive portions before it does ANY non-interactive!

In particular: we know that dbt docs generate and dbt run are expensive. Can we do EVERYTHING that we know is fast -- check on artifacts, check branching structure -- and just queue up a set of tasks?

Then we get some progress bars: "installing dbt. installing recce. running dbt docs . in [dev]" "running dbt run in [dev]"

Preferably, these are ordered by how long we expect them to take -- fast things first.

NEXT STEPS

I would love to see this also handle:

  • [offer to] log me into recce cloud & upload git config info
  • [offer to] upload artifacts for cloud summary

MINOR ISSUES (quality of life):

  • for the branch configuration, consider offering two checks:

    • "What is your main bracnh?" then "what is your dev branch?"
  • You've got time stamps on the artifacts -- and commit stamps on the git! "The artifact is xxx months old. There have been YYY commits since then."

  • When you install recce, might as well install recce[mcp] with it.

This was embarrassing

  • I asked for a lineage diff. The lineage diff invoked the /recce-pr skill, and the recce-pr skil ... turned around and invoked the lineage_diff. Also, I didn't have a PR!
  • It then fell back and GAVE UP on actually running recce. This seems like a really bad idea!
  • Worst, the thing it did was precisely the opposite of what I wanted, and it neglected our value! That is: in my branch, I added the amount_yen column! And the whole point of recce is that it does check the downstream for you! Even if this was right, it's hiding the importance of recce!
  1. ✅ Clean removal: The amount_yen column was removed from stg_payments, which is a straightforward change
  2. ⚠️ Check downstream usage: Verify that neither customers nor orders models reference amount_yen
  3. ⚠️ Schema difference: The schema name difference (main vs dev_danyel) is environment-specific and expect

(Meanwhile, Background command "Initialize Recce with cloud mode" failed with exit code 2)

Here's the full transcript of what asking for a "lineage_diff" did:

⏺ I'll run the lineage_diff analysis for you to show the changes between your branches.

⏺ Skill(recce-pr)
⎿  Successfully loaded skill

⏺ I'll analyze the data impact between your branches using Recce. Let me start by checking the MCP server status and then run the analysis.

⏺ Bash(bash /Users/danyel/.claude/plugins/cache/recce-plugins/recce-quickstart/0.1.0/scripts/check-mcp.sh)
⎿  STATUS=RUNNING
RECCE_MCP_PORT=8081
RECCE_MCP_URL=http://localhost:8081/sse
RECCE_MCP_PID=6085

⏺ Bash(git branch --show-current)
⎿  danyel-messes-around

⏺ Bash(gh pr view --json url -q .url 2>/dev/null || echo "NO_PR")
⎿  NO_PR

⏺ Perfect! The MCP server is running. Now let me analyze the changes between your branches using Recce's MCP tools. I'll start with the lineage diff to see what models have changed.

⏺ Bash(recce diff --select state:changed,state:added,state:removed 2>/dev/null || recce summary)
⎿  Error: Exit code 1
[Error] Recce can not launch without a state file.
Please provide a state file in the command argument.

⏺ Let me initialize Recce to create a state file first.

⏺ Bash(recce run --cloud-mode)
⎿  Running in the background (↓ to manage)

⏺ Let me take a different approach and directly analyze the manifest files to show you the lineage differences.

⏺ Bash(python3 << 'EOF'
import json…)
⎿  Running…

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions