Skip to content

Commit 12c3e97

Browse files
chore(internal): codegen related update
1 parent 195166f commit 12c3e97

2 files changed

Lines changed: 52 additions & 0 deletions

File tree

src/asktable/_base_client.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -540,6 +540,10 @@ def _build_request(
540540
files = cast(HttpxRequestFiles, ForceMultipartDict())
541541

542542
prepared_url = self._prepare_url(options.url)
543+
# preserve hard-coded query params from the url
544+
if params and prepared_url.query:
545+
params = {**dict(prepared_url.params.items()), **params}
546+
prepared_url = prepared_url.copy_with(raw_path=prepared_url.raw_path.split(b"?", 1)[0])
543547
if "_" in prepared_url.host:
544548
# work around https://github.com/encode/httpx/discussions/2880
545549
kwargs["extensions"] = {"sni_hostname": prepared_url.host.replace("_", "-")}

tests/test_client.py

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,30 @@ def test_default_query_option(self) -> None:
419419

420420
client.close()
421421

422+
def test_hardcoded_query_params_in_url(self, client: Asktable) -> None:
423+
request = client._build_request(FinalRequestOptions(method="get", url="/foo?beta=true"))
424+
url = httpx.URL(request.url)
425+
assert dict(url.params) == {"beta": "true"}
426+
427+
request = client._build_request(
428+
FinalRequestOptions(
429+
method="get",
430+
url="/foo?beta=true",
431+
params={"limit": "10", "page": "abc"},
432+
)
433+
)
434+
url = httpx.URL(request.url)
435+
assert dict(url.params) == {"beta": "true", "limit": "10", "page": "abc"}
436+
437+
request = client._build_request(
438+
FinalRequestOptions(
439+
method="get",
440+
url="/files/a%2Fb?beta=true",
441+
params={"limit": "10"},
442+
)
443+
)
444+
assert request.url.raw_path == b"/files/a%2Fb?beta=true&limit=10"
445+
422446
def test_request_extra_json(self, client: Asktable) -> None:
423447
request = client._build_request(
424448
FinalRequestOptions(
@@ -1304,6 +1328,30 @@ async def test_default_query_option(self) -> None:
13041328

13051329
await client.close()
13061330

1331+
async def test_hardcoded_query_params_in_url(self, async_client: AsyncAsktable) -> None:
1332+
request = async_client._build_request(FinalRequestOptions(method="get", url="/foo?beta=true"))
1333+
url = httpx.URL(request.url)
1334+
assert dict(url.params) == {"beta": "true"}
1335+
1336+
request = async_client._build_request(
1337+
FinalRequestOptions(
1338+
method="get",
1339+
url="/foo?beta=true",
1340+
params={"limit": "10", "page": "abc"},
1341+
)
1342+
)
1343+
url = httpx.URL(request.url)
1344+
assert dict(url.params) == {"beta": "true", "limit": "10", "page": "abc"}
1345+
1346+
request = async_client._build_request(
1347+
FinalRequestOptions(
1348+
method="get",
1349+
url="/files/a%2Fb?beta=true",
1350+
params={"limit": "10"},
1351+
)
1352+
)
1353+
assert request.url.raw_path == b"/files/a%2Fb?beta=true&limit=10"
1354+
13071355
def test_request_extra_json(self, client: Asktable) -> None:
13081356
request = client._build_request(
13091357
FinalRequestOptions(

0 commit comments

Comments
 (0)