Skip to content

Commit d0dfb88

Browse files
committed
Stand-alone version: no 'invalid dependencies' msg
1 parent 2f66ab4 commit d0dfb88

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ for future and past milestones.
3636
* In future releases, the installer will support installing shortcuts for all
3737
users if there is a demand for it (see [Issue #5](https://github.com/Codra-Ingenierie-Informatique/DataLab/issues/5))
3838
* [Issue #4](https://github.com/Codra-Ingenierie-Informatique/DataLab/issues/4) - Windows: stand-alone version shortcuts not showing in current user start menu
39+
* Installation and configuration window for stand-alone version:
40+
* Do not show ambiguous error message 'Invalid dependencies' anymore
41+
* Dependencies are supposed to be checked when building the stand-alone version
3942

4043
## DataLab Version 0.9.0 ##
4144

cdl/widgets/instconfviewer.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,22 +47,22 @@ def get_install_infos() -> str:
4747
Returns:
4848
str: installation informations
4949
"""
50-
more_infos = ""
51-
try:
52-
state = dephash.check_dependencies_hash(DATAPATH)
53-
bad_deps = [name for name in state if not state[name]]
54-
if bad_deps:
55-
more_infos += "Invalid dependencies: "
56-
more_infos += ", ".join(bad_deps)
57-
else:
58-
more_infos += "Dependencies hash file: checked."
59-
except IOError:
60-
more_infos += "Unable to open dependencies hash file."
61-
more_infos += os.linesep * 2
6250
if IS_FROZEN:
6351
# Stand-alone version
64-
more_infos += "This is the Stand-alone version of DataLab"
52+
more_infos = "This is the Stand-alone version of DataLab"
6553
else:
54+
more_infos = ""
55+
try:
56+
state = dephash.check_dependencies_hash(DATAPATH)
57+
bad_deps = [name for name in state if not state[name]]
58+
if bad_deps:
59+
more_infos += "Invalid dependencies: "
60+
more_infos += ", ".join(bad_deps)
61+
else:
62+
more_infos += "Dependencies hash file: checked."
63+
except IOError:
64+
more_infos += "Unable to open dependencies hash file."
65+
more_infos += os.linesep * 2
6666
more_infos += get_pip_list()
6767
infos = os.linesep.join(
6868
[

0 commit comments

Comments
 (0)