Fix: enable ROI editing for multiple selected signals or images

Fix #135

Author: PierreRaybaut

CHANGELOG.md

@@ -15,6 +15,10 @@ See DataLab [roadmap page](https://datalab-platform.com/en/contributing/roadmap.
   * This is now fixed: the "One curve per result title" mode now takes into account the ROI defined on the objects, and plots the selected result for each object (signal or image) and for each ROI defined on the object
 * Fixed [Issue #128](https://github.com/DataLab-Platform/DataLab/issues/128) - Support long object titles in Signal and Image panels
 * Fixed [Issue #133](https://github.com/DataLab-Platform/DataLab/issues/133) - Remove specific analysis results from metadata clipboard during copy operation
+* Fixed [Issue #135](https://github.com/DataLab-Platform/DataLab/issues/135) - Allow to edit ROI on multiple signals or images at once
+  * Before this fix, the ROI editor was disabled when multiple signals or images were selected
+  * This is now fixed: the ROI editor is now enabled when multiple signals or images are selected, and the ROI is applied to all selected signals or images (only the ROI of the first selected signal or image is taken into account)
+  * This new behavior is consistent with the ROI extraction feature, which allows to extract the ROI on multiple signals or images at once, based on the ROI defined on the first selected signal or image
 * Image ROI features:
   * Fixed [Issue #120](https://github.com/DataLab-Platform/DataLab/issues/120) - ROI extraction on multiple images: defined ROI should not be saved in the first selected object. The design choice is to save the defined ROI neither in the first nor in any of the selected objects: the ROI is only used for the extraction, and is not saved in any object
   * Fixed [Issue #121](https://github.com/DataLab-Platform/DataLab/issues/121) - `AttributeError` when extracting multiple ROIs on a single image, if more than one image is selected

cdl/core/gui/actionhandler.py

@@ -548,7 +548,6 @@ def create_first_actions(self):
                 separator=True,
                 triggered=self.panel.processor.edit_regions_of_interest,
                 icon_name="roi.svg",
-                select_condition=SelectCond.exactly_one,
                 context_menu_pos=-1,
                 context_menu_sep=True,
                 toolbar_pos=-1,

cdl/core/gui/panel/base.py

@@ -1088,6 +1088,7 @@ def get_roi_editor_output(self, extract: bool) -> tuple[TypeROI, bool] | None:
         obj = self.objview.get_sel_objects(include_groups=True)[0]
 
         # Create a new dialog
+
         dlg = self.create_new_dialog(
             edit=True,
             toolbar=True,
@@ -1099,9 +1100,20 @@ def get_roi_editor_output(self, extract: bool) -> tuple[TypeROI, bool] | None:
             return None
 
         # Create ROI editor (and add it to the dialog)
-        # pylint: disable=not-callable
+
+        if obj.uuid not in self.plothandler:
+            # This happens for example when opening an already saved workspace with
+            # multiple images, and if the user tries to edit the ROI of a group of
+            # images without having selected any object yet. In this case, only the
+            # last image is actually plotted (because if the other have the same size
+            # and position, they are hidden), and the plot item of the first image is
+            # not created yet. The `obj.uuid` is precisely the uuid of the first image.
+            self.plothandler.refresh_plot("selected", True, True)
         item = obj.make_item(update_from=self.plothandler[obj.uuid])
+
+        # pylint: disable=not-callable
         roi_editor = self.get_roieditor_class()(dlg, obj, extract, item=item)
+
         dlg.button_layout.insertWidget(0, roi_editor)
 
         if exec_dialog(dlg):

cdl/core/gui/processor/base.py

@@ -1045,7 +1045,8 @@ def edit_regions_of_interest(
         if results is None:
             return None
         edited_roi, modified = results
-        obj = self.panel.objview.get_sel_objects(include_groups=True)[0]
+        objs = self.panel.objview.get_sel_objects(include_groups=True)
+        obj = objs[0]
         group = edited_roi.to_params(obj)
         if (
             env.execenv.unattended  # Unattended mode (automated unit tests)
@@ -1059,9 +1060,11 @@ def edit_regions_of_interest(
                 else:
                     edited_roi = edited_roi.from_params(obj, group)
                     if not extract:
-                        obj.roi = edited_roi
+                        for obj_i in objs:
+                            obj_i.roi = edited_roi
                 self.SIG_ADD_SHAPE.emit(obj.uuid)
-                self.panel.selection_changed(update_items=True)
+                # self.panel.selection_changed(update_items=True)
+                self.panel.manual_refresh()
         return edited_roi
 
     def delete_regions_of_interest(self) -> None: