Image average profile extraction: AttributeError when trying to edit profile parameters

Fix #87

Author: PierreRaybaut

CHANGELOG.md

@@ -14,6 +14,7 @@ See DataLab [roadmap page](https://datalab-platform.com/en/contributing/roadmap.
   * Adding the test data paths multiple times to `cdl.utils.tests.TST_PATH` was causing the test data to be loaded multiple times, which lead to some tests failing (a simple workaround was added to V0.16.2: this issue is now fixed)
   * Thanks again to [@rolandmas](https://github.com/rolandmas) for reporting the issue in the context of the Debian packaging
 * Fixed [Issue #86](https://github.com/DataLab-Platform/DataLab/issues/86) - Average of N integer images overflows data type
+* Fixed [Issue #87](https://github.com/DataLab-Platform/DataLab/issues/87) - Image average profile extraction: `AttributeError` when trying to edit profile parameters
 
 ## DataLab Version 0.16.2 ##
 

cdl/core/gui/profiledialog.py

@@ -298,6 +298,7 @@ def set_obj(self, obj: ImageObj):
                 p0 = QC.QPointF(*axes_to_canvas(item, x1, y1))
                 p1 = QC.QPointF(*axes_to_canvas(item, x2, y2))
             self.cstool.add_shape_to_plot(plot, p0, p1)
+            self.shape = self.cstool.get_last_final_shape()
             self.param_btn.setEnabled(True)
             self.button_box.button(QW.QDialogButtonBox.Ok).setEnabled(True)
         else:

cdl/tests/features/images/profile_unit_test.py

@@ -24,6 +24,10 @@ def test_profile_unit():
                 if initial_param:
                     if mode == "line":
                         param = cdl.param.LineProfileParam.create(row=100, col=200)
+                    elif mode == "segment":
+                        param = cdl.param.SegmentProfileParam.create(
+                            row1=10, col1=20, row2=200, col2=300
+                        )
                     else:
                         param = cdl.param.AverageProfileParam.create(
                             row1=10, col1=20, row2=200, col2=300
@@ -41,6 +45,8 @@ def test_profile_unit():
                     mode, param, add_initial_shape=initial_param
                 )
                 dialog.set_obj(obj)
+                if initial_param:
+                    dialog.edit_values()
                 ok = exec_dialog(dialog)
                 execenv.print(f"Returned code: {ok}")
                 execenv.print(f"Param: {param}")