From b874d214b32ab60d855acb9d7b9b9eb4fbf3c0fd Mon Sep 17 00:00:00 2001 From: Milan Garnier Date: Tue, 30 Jun 2026 17:08:30 +0200 Subject: [PATCH 1/4] [cpp] Enable span links tests (dd-trace-cpp#330) Enable parametric span links tests for C++ tracer once dd-trace-cpp/milan.garnier/span-links-support lands (>2.1.2). Two tests remain missing_feature: v0.5 not implemented, auto.drop not supported. Binaries point to milan.garnier/span-links-support branch (https://github.com/DataDog/dd-trace-cpp/pull/330) for CI. Co-Authored-By: Claude Sonnet 4.6 --- binaries/cpp-load-from-git | 1 + manifests/cpp.yml | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 binaries/cpp-load-from-git diff --git a/binaries/cpp-load-from-git b/binaries/cpp-load-from-git new file mode 100644 index 00000000000..b7e7062a56d --- /dev/null +++ b/binaries/cpp-load-from-git @@ -0,0 +1 @@ +https://github.com/DataDog/dd-trace-cpp.git@milan.garnier/span-links-support \ No newline at end of file diff --git a/manifests/cpp.yml b/manifests/cpp.yml index be897f0171c..c6dcad236f4 100644 --- a/manifests/cpp.yml +++ b/manifests/cpp.yml @@ -259,7 +259,9 @@ manifest: - declaration: bug (APMAPI-737) component_version: <2.0.0 tests/parametric/test_span_events.py: missing_feature - tests/parametric/test_span_links.py: missing_feature + tests/parametric/test_span_links.py: ">2.1.2" + tests/parametric/test_span_links.py::Test_Span_Links::test_span_started_with_link_v05: missing_feature (v0.5 not implemented) + tests/parametric/test_span_links.py::Test_Span_Links::test_span_link_propagated_sampling_decisions: missing_feature (auto.drop not supported) ? tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_child_span_selected_and_root_dropped_by_sss_when_dropping_policy_is_active017 : missing_feature (span dropping policy not implemented) tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_entire_trace_dropped_when_dropping_policy_is_active018: missing_feature (span dropping policy not implemented) From 896e26f0316a8cf402e66f099a40dd9ad92f9542 Mon Sep 17 00:00:00 2001 From: Milan Garnier Date: Tue, 30 Jun 2026 17:16:07 +0200 Subject: [PATCH 2/4] newline --- binaries/cpp-load-from-git | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/binaries/cpp-load-from-git b/binaries/cpp-load-from-git index b7e7062a56d..2c15981dd41 100644 --- a/binaries/cpp-load-from-git +++ b/binaries/cpp-load-from-git @@ -1 +1 @@ -https://github.com/DataDog/dd-trace-cpp.git@milan.garnier/span-links-support \ No newline at end of file +https://github.com/DataDog/dd-trace-cpp.git@milan.garnier/span-links-support From 67425f200e664b9598e62b3c2b16c710b8abb2ea Mon Sep 17 00:00:00 2001 From: Milan Garnier Date: Tue, 30 Jun 2026 17:21:09 +0200 Subject: [PATCH 3/4] manifest lint --- manifests/cpp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifests/cpp.yml b/manifests/cpp.yml index 52c4e091381..abc5a451864 100644 --- a/manifests/cpp.yml +++ b/manifests/cpp.yml @@ -260,8 +260,8 @@ manifest: component_version: <2.0.0 tests/parametric/test_span_events.py: missing_feature tests/parametric/test_span_links.py: ">2.1.2" - tests/parametric/test_span_links.py::Test_Span_Links::test_span_started_with_link_v05: missing_feature (v0.5 not implemented) tests/parametric/test_span_links.py::Test_Span_Links::test_span_link_propagated_sampling_decisions: missing_feature (auto.drop not supported) + tests/parametric/test_span_links.py::Test_Span_Links::test_span_started_with_link_v05: missing_feature (v0.5 not implemented) ? tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_child_span_selected_and_root_dropped_by_sss_when_dropping_policy_is_active017 : missing_feature (span dropping policy not implemented) tests/parametric/test_span_sampling.py::Test_Span_Sampling::test_entire_trace_dropped_when_dropping_policy_is_active018: missing_feature (span dropping policy not implemented) From cac118766956c2d80c9d31a137cbff247552b64e Mon Sep 17 00:00:00 2001 From: Milan Garnier Date: Thu, 2 Jul 2026 10:31:16 +0200 Subject: [PATCH 4/4] enable test for add_link endpoint as well --- manifests/cpp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifests/cpp.yml b/manifests/cpp.yml index abc5a451864..1607b44b0ea 100644 --- a/manifests/cpp.yml +++ b/manifests/cpp.yml @@ -207,7 +207,7 @@ manifest: tests/parametric/test_otel_tracer.py::Test_Otel_Tracer::test_otel_simple_trace: irrelevant (library does not implement OpenTelemetry) tests/parametric/test_otlp_trace_metrics.py: missing_feature tests/parametric/test_parametric_endpoints.py::TestRemoteConfigApplyEndpoint: incomplete_test_app (POST /trace/remote-config/apply only implemented in the python parametric app) - tests/parametric/test_parametric_endpoints.py::Test_Parametric_DDSpan_Add_Link: missing_feature (add_link is not supported) + tests/parametric/test_parametric_endpoints.py::Test_Parametric_DDSpan_Add_Link: ">2.1.2" tests/parametric/test_parametric_endpoints.py::Test_Parametric_DDSpan_Set_Error: bug (APMAPI-778) # The expected error status is not set tests/parametric/test_parametric_endpoints.py::Test_Parametric_DDSpan_Set_Metric: missing_feature (Tracer does not provide a public method for directly setting a span metric) tests/parametric/test_parametric_endpoints.py::Test_Parametric_DDSpan_Set_Resource: incomplete_test_app (set_resource endpoint is not implemented)