From 1410323807bfd013eec3cd6fda4a54a5a833e7a9 Mon Sep 17 00:00:00 2001 From: ishabi Date: Tue, 31 Mar 2026 17:19:30 +0200 Subject: [PATCH 1/7] remove pprof version override --- scenarios/node_code_hotspots/package.json | 5 +---- scenarios/node_heap/README.md | 2 +- scenarios/node_heap/expected_profile.json | 6 +++--- scenarios/node_heap/package.json | 5 +---- scenarios/node_heap_oom/package.json | 5 +---- scenarios/node_wall_cpu/package.json | 5 +---- 6 files changed, 8 insertions(+), 20 deletions(-) diff --git a/scenarios/node_code_hotspots/package.json b/scenarios/node_code_hotspots/package.json index 8befece..baa0e06 100644 --- a/scenarios/node_code_hotspots/package.json +++ b/scenarios/node_code_hotspots/package.json @@ -6,8 +6,5 @@ "dependencies": { "dd-trace": "DataDog/dd-trace-js#master" }, - "overrides": { - "@datadog/pprof": "dev" - }, "scale_by_duration": true -} \ No newline at end of file +} diff --git a/scenarios/node_heap/README.md b/scenarios/node_heap/README.md index cdf2ea6..5a8433b 100644 --- a/scenarios/node_heap/README.md +++ b/scenarios/node_heap/README.md @@ -14,7 +14,7 @@ Both functions are called once per iteration in a timed loop, creating equal **n **Objects Profile**: Should count allocation instances - Theoretically: 50% `a` / 50% `b` (equal number of calls) -- Actually measured: 33% `a` / 66% `b` (biased toward larger objects) +- Measured: Matches expectations **Space Profile**: Should count memory usage - Expected: 33% `a` / 66% `b` (proportional to allocation sizes) diff --git a/scenarios/node_heap/expected_profile.json b/scenarios/node_heap/expected_profile.json index 495de7a..fa5240f 100644 --- a/scenarios/node_heap/expected_profile.json +++ b/scenarios/node_heap/expected_profile.json @@ -6,12 +6,12 @@ "stack-content": [ { "regular_expression": "processTimers;listOnTimeout;work;b;slice", - "percent": 66, + "percent": 50, "error_margin": 5 }, { "regular_expression": "processTimers;listOnTimeout;work;a;slice", - "percent": 33, + "percent": 50, "error_margin": 5 } ] @@ -35,4 +35,4 @@ } ], "scale_by_duration": true -} \ No newline at end of file +} diff --git a/scenarios/node_heap/package.json b/scenarios/node_heap/package.json index 8befece..baa0e06 100644 --- a/scenarios/node_heap/package.json +++ b/scenarios/node_heap/package.json @@ -6,8 +6,5 @@ "dependencies": { "dd-trace": "DataDog/dd-trace-js#master" }, - "overrides": { - "@datadog/pprof": "dev" - }, "scale_by_duration": true -} \ No newline at end of file +} diff --git a/scenarios/node_heap_oom/package.json b/scenarios/node_heap_oom/package.json index 8befece..baa0e06 100644 --- a/scenarios/node_heap_oom/package.json +++ b/scenarios/node_heap_oom/package.json @@ -6,8 +6,5 @@ "dependencies": { "dd-trace": "DataDog/dd-trace-js#master" }, - "overrides": { - "@datadog/pprof": "dev" - }, "scale_by_duration": true -} \ No newline at end of file +} diff --git a/scenarios/node_wall_cpu/package.json b/scenarios/node_wall_cpu/package.json index 8befece..baa0e06 100644 --- a/scenarios/node_wall_cpu/package.json +++ b/scenarios/node_wall_cpu/package.json @@ -6,8 +6,5 @@ "dependencies": { "dd-trace": "DataDog/dd-trace-js#master" }, - "overrides": { - "@datadog/pprof": "dev" - }, "scale_by_duration": true -} \ No newline at end of file +} From 4e7f5403d07fef8b3d86af19a97cfc8bd9fd7984 Mon Sep 17 00:00:00 2001 From: ishabi Date: Tue, 31 Mar 2026 18:15:01 +0200 Subject: [PATCH 2/7] disable source maps in node heap --- scenarios/node_heap/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/scenarios/node_heap/Dockerfile b/scenarios/node_heap/Dockerfile index 574ae94..392965f 100644 --- a/scenarios/node_heap/Dockerfile +++ b/scenarios/node_heap/Dockerfile @@ -16,4 +16,5 @@ ENV DD_TRACING_ENABLED=0 ENV DD_REMOTE_CONFIGURATION_ENABLED=0 ENV DD_PROFILING_PROFILERS=space ENV DD_TRACE_DEBUG=1 +ENV DD_PROFILING_DEBUG_SOURCE_MAPS=0 CMD node --expose-gc -r dd-trace/init main.js From 8736815ce85cbc6e339a6bc0cdea1640acf87b44 Mon Sep 17 00:00:00 2001 From: ishabi Date: Wed, 1 Apr 2026 15:57:53 +0200 Subject: [PATCH 3/7] resotre dev tag --- scenarios/node_code_hotspots/package.json | 3 +++ scenarios/node_heap/package.json | 3 +++ scenarios/node_heap_oom/package.json | 3 +++ scenarios/node_wall_cpu/package.json | 3 +++ 4 files changed, 12 insertions(+) diff --git a/scenarios/node_code_hotspots/package.json b/scenarios/node_code_hotspots/package.json index baa0e06..4a7e341 100644 --- a/scenarios/node_code_hotspots/package.json +++ b/scenarios/node_code_hotspots/package.json @@ -6,5 +6,8 @@ "dependencies": { "dd-trace": "DataDog/dd-trace-js#master" }, + "overrides": { + "@datadog/pprof": "dev" + }, "scale_by_duration": true } diff --git a/scenarios/node_heap/package.json b/scenarios/node_heap/package.json index baa0e06..4a7e341 100644 --- a/scenarios/node_heap/package.json +++ b/scenarios/node_heap/package.json @@ -6,5 +6,8 @@ "dependencies": { "dd-trace": "DataDog/dd-trace-js#master" }, + "overrides": { + "@datadog/pprof": "dev" + }, "scale_by_duration": true } diff --git a/scenarios/node_heap_oom/package.json b/scenarios/node_heap_oom/package.json index baa0e06..4a7e341 100644 --- a/scenarios/node_heap_oom/package.json +++ b/scenarios/node_heap_oom/package.json @@ -6,5 +6,8 @@ "dependencies": { "dd-trace": "DataDog/dd-trace-js#master" }, + "overrides": { + "@datadog/pprof": "dev" + }, "scale_by_duration": true } diff --git a/scenarios/node_wall_cpu/package.json b/scenarios/node_wall_cpu/package.json index baa0e06..4a7e341 100644 --- a/scenarios/node_wall_cpu/package.json +++ b/scenarios/node_wall_cpu/package.json @@ -6,5 +6,8 @@ "dependencies": { "dd-trace": "DataDog/dd-trace-js#master" }, + "overrides": { + "@datadog/pprof": "dev" + }, "scale_by_duration": true } From e1bc472fb1846f656ed7bb28eb70d20e5533c2bd Mon Sep 17 00:00:00 2001 From: ishabi Date: Wed, 1 Apr 2026 16:02:42 +0200 Subject: [PATCH 4/7] restore old percentages --- scenarios/node_heap/Dockerfile | 1 - scenarios/node_heap/README.md | 2 +- scenarios/node_heap/expected_profile.json | 4 ++-- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/scenarios/node_heap/Dockerfile b/scenarios/node_heap/Dockerfile index 392965f..574ae94 100644 --- a/scenarios/node_heap/Dockerfile +++ b/scenarios/node_heap/Dockerfile @@ -16,5 +16,4 @@ ENV DD_TRACING_ENABLED=0 ENV DD_REMOTE_CONFIGURATION_ENABLED=0 ENV DD_PROFILING_PROFILERS=space ENV DD_TRACE_DEBUG=1 -ENV DD_PROFILING_DEBUG_SOURCE_MAPS=0 CMD node --expose-gc -r dd-trace/init main.js diff --git a/scenarios/node_heap/README.md b/scenarios/node_heap/README.md index 5a8433b..cdf2ea6 100644 --- a/scenarios/node_heap/README.md +++ b/scenarios/node_heap/README.md @@ -14,7 +14,7 @@ Both functions are called once per iteration in a timed loop, creating equal **n **Objects Profile**: Should count allocation instances - Theoretically: 50% `a` / 50% `b` (equal number of calls) -- Measured: Matches expectations +- Actually measured: 33% `a` / 66% `b` (biased toward larger objects) **Space Profile**: Should count memory usage - Expected: 33% `a` / 66% `b` (proportional to allocation sizes) diff --git a/scenarios/node_heap/expected_profile.json b/scenarios/node_heap/expected_profile.json index fa5240f..ddad2cb 100644 --- a/scenarios/node_heap/expected_profile.json +++ b/scenarios/node_heap/expected_profile.json @@ -6,12 +6,12 @@ "stack-content": [ { "regular_expression": "processTimers;listOnTimeout;work;b;slice", - "percent": 50, + "percent": 66, "error_margin": 5 }, { "regular_expression": "processTimers;listOnTimeout;work;a;slice", - "percent": 50, + "percent": 33, "error_margin": 5 } ] From b3dd983ad288fcccd3f0fcd859e2a2274e8bb1e0 Mon Sep 17 00:00:00 2001 From: ishabi Date: Wed, 1 Apr 2026 16:44:56 +0200 Subject: [PATCH 5/7] disable source maps loading --- scenarios/node_heap/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/scenarios/node_heap/Dockerfile b/scenarios/node_heap/Dockerfile index 574ae94..392965f 100644 --- a/scenarios/node_heap/Dockerfile +++ b/scenarios/node_heap/Dockerfile @@ -16,4 +16,5 @@ ENV DD_TRACING_ENABLED=0 ENV DD_REMOTE_CONFIGURATION_ENABLED=0 ENV DD_PROFILING_PROFILERS=space ENV DD_TRACE_DEBUG=1 +ENV DD_PROFILING_DEBUG_SOURCE_MAPS=0 CMD node --expose-gc -r dd-trace/init main.js From 18970652bc9a3be31c7c5379dc7d12640758fd12 Mon Sep 17 00:00:00 2001 From: ishabi Date: Wed, 1 Apr 2026 17:18:16 +0200 Subject: [PATCH 6/7] update estimations --- scenarios/node_heap/expected_profile.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scenarios/node_heap/expected_profile.json b/scenarios/node_heap/expected_profile.json index ddad2cb..2e65cf0 100644 --- a/scenarios/node_heap/expected_profile.json +++ b/scenarios/node_heap/expected_profile.json @@ -6,13 +6,13 @@ "stack-content": [ { "regular_expression": "processTimers;listOnTimeout;work;b;slice", - "percent": 66, - "error_margin": 5 + "percent": 50, + "error_margin": 10 }, { "regular_expression": "processTimers;listOnTimeout;work;a;slice", - "percent": 33, - "error_margin": 5 + "percent": 50, + "error_margin": 10 } ] }, From cbf8287380e4c94f8f99ed464d40c2e2464fed98 Mon Sep 17 00:00:00 2001 From: ishabi Date: Thu, 2 Apr 2026 14:55:24 +0200 Subject: [PATCH 7/7] remove source map since it's disabled by default --- scenarios/node_heap/Dockerfile | 1 - 1 file changed, 1 deletion(-) diff --git a/scenarios/node_heap/Dockerfile b/scenarios/node_heap/Dockerfile index 392965f..574ae94 100644 --- a/scenarios/node_heap/Dockerfile +++ b/scenarios/node_heap/Dockerfile @@ -16,5 +16,4 @@ ENV DD_TRACING_ENABLED=0 ENV DD_REMOTE_CONFIGURATION_ENABLED=0 ENV DD_PROFILING_PROFILERS=space ENV DD_TRACE_DEBUG=1 -ENV DD_PROFILING_DEBUG_SOURCE_MAPS=0 CMD node --expose-gc -r dd-trace/init main.js