`"PROFILE" =>Not a blocker, but I'd still really like these defaults to come from the builder crate, not our side ;)
Originally posted by @ivoanjo in #33 (comment) "release"`
I think is OK to keep, as it's fairly generic, well understood, and I hesitated having it optionally selectable to debug in this very PR, which comes in handy for local development. The code here would have then read "PROFILE" => profile and other references to 'release' replaced with profile, itself defaulting to 'release'.
Originally posted by @lloeki in #33 (comment)
"OPT_LEVEL" => "3" is an obscure implementation detail and non-obvious what it applies to (AIUI cmake for crashtracker?), it may be overridable but should be encapsulated by builder. We should remove it from here in a future PR once it lands in builder.
Originally posted by @lloeki in #33 (comment)
We can safely remove the following env vars:
- OPT_LEVEL
- HOST
- OUT_DIR
Originally posted by @hoolioh in #33 (comment)
`"PROFILE" =>Not a blocker, but I'd still really like these defaults to come from the builder crate, not our side ;)
Originally posted by @ivoanjo in #33 (comment) "release"`
I think is OK to keep, as it's fairly generic, well understood, and I hesitated having it optionally selectable to
debugin this very PR, which comes in handy for local development. The code here would have then read"PROFILE" => profileand other references to'release'replaced withprofile, itself defaulting to'release'.Originally posted by @lloeki in #33 (comment)
"OPT_LEVEL" => "3"is an obscure implementation detail and non-obvious what it applies to (AIUIcmakefor crashtracker?), it may be overridable but should be encapsulated bybuilder. We should remove it from here in a future PR once it lands inbuilder.Originally posted by @lloeki in #33 (comment)
We can safely remove the following env vars:
Originally posted by @hoolioh in #33 (comment)