test(crashtracker): replace express with core http

Remove express and body-parser dependencies in favor of
Node.js core http module. This simplifies the test setup
and eliminates third-party dependencies. The yarn install
step is moved from the test runner script into the test
itself.

Author: watson

scripts/test.sh

@@ -2,12 +2,6 @@
 set -e
 
 run_test() {
-  local dir
-  dir=$(dirname "$1")
-  if [ -f "${dir}/package.json" ]; then
-    echo "Installing dependencies for $1"
-    yarn --cwd "$dir" install
-  fi
   echo "Running $1"
   node "$1"
 }

test/crashtracker/index.js

@@ -2,67 +2,84 @@
 
 const assert = require('node:assert')
 const { existsSync, rmSync } = require('node:fs')
+const http = require('node:http')
 const path = require('node:path')
 const { execSync, exec } = require('node:child_process')
 
-const bodyParser = require('body-parser')
-const express = require('express')
-
-const cwd = __dirname
-const stdio = ['inherit', 'inherit', 'inherit']
-const uid = process.getuid()
-const gid = process.getgid()
-const opts = { cwd, stdio, uid, gid }
+let currentTest
+let PORT
 
-const app = express()
+execSync('yarn install', getExecOptions())
 
-rmSync(path.join(cwd, 'stdout.log'), { force: true })
-rmSync(path.join(cwd, 'stderr.log'), { force: true })
+rmSync(path.join(__dirname, 'stdout.log'), { force: true })
+rmSync(path.join(__dirname, 'stderr.log'), { force: true })
 
 let timeout = setTimeout(() => {
-  execSync('cat stdout.log', opts)
-  execSync('cat stderr.log', opts)
+  execSync('cat stdout.log', getExecOptions())
+  execSync('cat stderr.log', getExecOptions())
 
   throw new Error('No crash report received before timing out.')
 }, 10_000)
 
-let currentTest
+const server = http.createServer((req, res) => {
+  if (req.method !== 'POST' || req.url !== '/telemetry/proxy/api/v2/apmtelemetry') {
+    res.writeHead(404).end()
+    return
+  }
 
-app.use(bodyParser.json())
+  const chunks = []
+  req.on('data', (chunk) => chunks.push(chunk))
+  req.on('end', () => {
+    res.writeHead(200).end()
 
-app.post('/telemetry/proxy/api/v2/apmtelemetry', (req, res) => {
-  res.status(200).send()
+    if (!currentTest) {
+      throw new Error('Received unexpected crash report with no active test.')
+    }
 
-  const logPayload = req.body.payload.logs[0]
-  const tags = logPayload.tags ? logPayload.tags.split(',') : []
+    const body = JSON.parse(Buffer.concat(chunks).toString())
+    const logPayload = body.payload.logs[0]
 
-  // Only process crash reports (not pings)
-  if (!logPayload.is_crash) {
-    return
-  }
+    // Only process crash reports (not pings)
+    if (!logPayload.is_crash) {
+      return
+    }
 
-  if (!currentTest) {
-    throw new Error('Received unexpected crash report with no active test.')
-  }
+    const tags = logPayload.tags ? logPayload.tags.split(',') : []
 
-  currentTest(logPayload, tags)
+    currentTest(logPayload, tags)
+  })
 })
 
-let PORT
-
-function runApp (script) {
-  return new Promise((resolve) => {
-    exec(`node ${script}`, {
-      ...opts,
-      env: { ...process.env, PORT },
-    })
+server.listen(async () => {
+  PORT = server.address().port
 
-    currentTest = (logPayload, tags) => {
-      currentTest = undefined
-      resolve({ logPayload, tags })
-    }
+  await testSegfault()
+  await testUnhandledError('uncaught-exception', 'app-uncaught-exception', {
+    expectedType: 'TypeError',
+    expectedMessage: 'something went wrong',
+    expectedFrame: 'myFaultyFunction',
   })
-}
+  await testUnhandledNonError('uncaught-exception-non-error', 'app-uncaught-exception-non-error', {
+    expectedFallbackType: 'uncaughtException',
+    expectedValue: 'a plain string error',
+  })
+  await testUnhandledError('unhandled-rejection', 'app-unhandled-rejection', {
+    expectedType: 'Error',
+    expectedMessage: 'async went wrong',
+    expectedFrame: 'myAsyncFaultyFunction',
+  })
+  // Node wraps non-Error rejections in an Error with name 'UnhandledPromiseRejection'
+  // before passing to uncaughtExceptionMonitor, so this hits the Error path.
+  // However, this test case rejects with a plain string, so the wrapped Error object has useless
+  // stack trace
+  await testUnhandledError('unhandled-rejection-non-error', 'app-unhandled-rejection-non-error', {
+    expectedType: 'UnhandledPromiseRejection',
+    expectedMessage: 'a plain string rejection',
+  })
+
+  clearTimeout(timeout)
+  server.close()
+})
 
 async function testSegfault () {
   const { logPayload, tags } = await runApp('app-seg-fault')
@@ -99,33 +116,25 @@ async function testUnhandledNonError (label, script, { expectedFallbackType, exp
   assert.strictEqual(crashReport.error.stack.frames.length, 0, `[${label}] Expected empty stack trace but got ${crashReport.error.stack.frames.length} frames.`)
 }
 
-const server = app.listen(async () => {
-  PORT = server.address().port
+function runApp (script) {
+  return new Promise((resolve) => {
+    exec(`node ${script}`, getExecOptions({
+      env: { ...process.env, PORT },
+    }))
 
-  await testSegfault()
-  await testUnhandledError('uncaught-exception', 'app-uncaught-exception', {
-    expectedType: 'TypeError',
-    expectedMessage: 'something went wrong',
-    expectedFrame: 'myFaultyFunction',
-  })
-  await testUnhandledNonError('uncaught-exception-non-error', 'app-uncaught-exception-non-error', {
-    expectedFallbackType: 'uncaughtException',
-    expectedValue: 'a plain string error',
-  })
-  await testUnhandledError('unhandled-rejection', 'app-unhandled-rejection', {
-    expectedType: 'Error',
-    expectedMessage: 'async went wrong',
-    expectedFrame: 'myAsyncFaultyFunction',
-  })
-  // Node wraps non-Error rejections in an Error with name 'UnhandledPromiseRejection'
-  // before passing to uncaughtExceptionMonitor, so this hits the Error path.
-  // However, this test case rejects with a plain string, so the wrapped Error object has useless
-  // stack trace
-  await testUnhandledError('unhandled-rejection-non-error', 'app-unhandled-rejection-non-error', {
-    expectedType: 'UnhandledPromiseRejection',
-    expectedMessage: 'a plain string rejection',
+    currentTest = (logPayload, tags) => {
+      currentTest = undefined
+      resolve({ logPayload, tags })
+    }
   })
+}
 
-  clearTimeout(timeout)
-  server.close()
-})
+function getExecOptions (opts) {
+  return {
+    cwd: __dirname,
+    stdio: 'inherit',
+    uid: process.getuid(),
+    gid: process.getgid(),
+    ...opts,
+  }
+}

test/crashtracker/package.json

@@ -2,8 +2,6 @@
   "private": true,
   "main": "index.js",
   "dependencies": {
-    "@datadog/segfaultify": "^0.1.1",
-    "body-parser": "^1.20.3",
-    "express": "^4.19.2"
+    "@datadog/segfaultify": "^0.1.1"
   }
 }