chore: add eslint-plugin-import-x

Enforce import ordering, grouping with newlines between sections, no
unnecessary extensions, and other import best practices across the
codebase.

Author: watson

eslint.config.js

@@ -1,5 +1,6 @@
 'use strict'
 
+const eslintPluginImportX = require('eslint-plugin-import-x')
 const eslintPluginJs = require('@eslint/js')
 const eslintPluginN = require('eslint-plugin-n')
 const eslintPluginStylistic = require('@stylistic/eslint-plugin')
@@ -8,18 +9,28 @@ const globals = require('globals')
 
 module.exports = [
   eslintPluginJs.configs.recommended,
+  eslintPluginImportX.flatConfigs.recommended,
   eslintPluginN.configs['flat/recommended-script'],
   eslintPluginStylistic.configs.recommended,
   eslintPluginUnicorn.configs.recommended,
   {
     languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: 'commonjs',
       globals: {
+        ...globals.es2022,
         ...globals.node,
       },
     },
     rules: {
       '@stylistic/brace-style': ['error', '1tbs'],
       '@stylistic/space-before-function-paren': ['error', 'always'],
+      'import-x/extensions': ['error', 'never', { json: 'always' }],
+      'import-x/no-absolute-path': 'error',
+      'import-x/no-webpack-loader-syntax': 'error',
+      'import-x/order': ['error', {
+        'newlines-between': 'always',
+      }],
       'n/no-process-exit': 'off', // Duplicate of unicorn/no-process-exit
       'unicorn/prefer-module': 'off', // We use CJS
       'unicorn/prevent-abbreviations': 'off',

package.json

@@ -33,6 +33,7 @@
     "@eslint/js": "^10.0.1",
     "@stylistic/eslint-plugin": "^5.9.0",
     "eslint": "^10.0.2",
+    "eslint-plugin-import-x": "^4.12.2",
     "eslint-plugin-n": "^17.24.0",
     "eslint-plugin-unicorn": "^63.0.0",
     "globals": "^17.4.0"

test/crashtracker/app-seg-fault.js

@@ -1,9 +1,11 @@
 'use strict'
 
 const libdatadog = require('../..')
-const crashtracker = libdatadog.load('crashtracker')
+
 const { initTestCrashtracker } = require('./test-utils')
 
+const crashtracker = libdatadog.load('crashtracker')
+
 initTestCrashtracker()
 crashtracker.beginProfilerSerializing()
 require('@datadog/segfaultify').segfaultify()

test/crashtracker/app-uncaught-exception-non-error.js

@@ -1,9 +1,11 @@
 'use strict'
 
 const libdatadog = require('../..')
-const crashtracker = libdatadog.load('crashtracker')
+
 const { initTestCrashtracker } = require('./test-utils')
 
+const crashtracker = libdatadog.load('crashtracker')
+
 initTestCrashtracker()
 crashtracker.beginProfilerSerializing()
 

test/crashtracker/app-uncaught-exception.js

@@ -1,9 +1,11 @@
 'use strict'
 
 const libdatadog = require('../..')
-const crashtracker = libdatadog.load('crashtracker')
+
 const { initTestCrashtracker } = require('./test-utils')
 
+const crashtracker = libdatadog.load('crashtracker')
+
 initTestCrashtracker()
 crashtracker.beginProfilerSerializing()
 

test/crashtracker/app-unhandled-rejection-non-error.js

@@ -1,9 +1,11 @@
 'use strict'
 
 const libdatadog = require('../..')
-const crashtracker = libdatadog.load('crashtracker')
+
 const { initTestCrashtracker } = require('./test-utils')
 
+const crashtracker = libdatadog.load('crashtracker')
+
 initTestCrashtracker()
 crashtracker.beginProfilerSerializing()
 

test/crashtracker/app-unhandled-rejection.js

@@ -1,9 +1,11 @@
 'use strict'
 
 const libdatadog = require('../..')
-const crashtracker = libdatadog.load('crashtracker')
+
 const { initTestCrashtracker } = require('./test-utils')
 
+const crashtracker = libdatadog.load('crashtracker')
+
 initTestCrashtracker()
 crashtracker.beginProfilerSerializing()
 

test/crashtracker/index.js

@@ -1,7 +1,13 @@
 'use strict'
 
+const assert = require('node:assert')
+const { existsSync, rmSync } = require('node:fs')
+const path = require('node:path')
 const { execSync, exec } = require('node:child_process')
 
+const bodyParser = require('body-parser')
+const express = require('express')
+
 const cwd = __dirname
 const stdio = ['inherit', 'inherit', 'inherit']
 const uid = process.getuid()
@@ -10,12 +16,6 @@ const opts = { cwd, stdio, uid, gid }
 
 execSync('yarn install', opts)
 
-const express = require('express')
-const bodyParser = require('body-parser')
-const assert = require('node:assert')
-const { existsSync, rmSync } = require('node:fs')
-const path = require('node:path')
-
 const app = express()
 
 rmSync(path.join(cwd, 'stdout.log'), { force: true })

test/wasm/datadog-js-zstd/index.js

@@ -1,6 +1,7 @@
-const loader = require('../../../load.js')
 const assert = require('node:assert')
 
+const loader = require('../../../load')
+
 const zstd = loader.load('datadog-js-zstd')
 assert(zstd !== undefined)
 

test/wasm/library_config/index.js

@@ -1,7 +1,8 @@
-const path = require('node:path')
-const fs = require('node:fs')
-const loader = require('../../../load.js')
 const assert = require('node:assert')
+const fs = require('node:fs')
+const path = require('node:path')
+
+const loader = require('../../../load')
 
 const libconfig = loader.load('library_config')
 assert(libconfig !== undefined)