Skip to content

Commit 52876ec

Browse files
"tighten" value and error for this test
On PHP >= 8.4 (with frameless functions), typical CPU utilization of that `str_replace()` function is at around 51%, without frameless functions (PHP <= 8.3) the CPU utilisation for `str_replace()` is at about 99%, this runs that test always and makes sure we match both cases.
1 parent 9cb6ba1 commit 52876ec

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

.github/workflows/prof_correctness.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ jobs:
111111
unset DD_PROFILING_ALLOCATION_SAMPLING_DISTANCE
112112
113113
- name: Run allocation_time_combined test (PHP 8.4+)
114-
if: fromJSON(matrix.php-version) >= 8.4
115114
run: |
116115
export DD_PROFILING_LOG_LEVEL=trace
117116
export DD_PROFILING_EXPERIMENTAL_FEATURES_ENABLED=1
@@ -182,7 +181,6 @@ jobs:
182181
pprof_path: profiling/tests/correctness/timeline/
183182

184183
- name: Check profiler correctness for allocation_time_combined
185-
if: fromJSON(matrix.php-version) >= 8.4
186184
uses: Datadog/prof-correctness/analyze@main
187185
with:
188186
expected_json: profiling/tests/correctness/allocation_time_combined.json

profiling/tests/correctness/allocation_time_combined.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@
3737
"stack-content": [
3838
{
3939
"regular_expression": "<?php;main;standard\\|str_replace$",
40-
"percent": 51,
41-
"error_margin": 50
40+
"percent": 70,
41+
"error_margin": 30
4242
}
4343
]
4444
}

0 commit comments

Comments
 (0)