Remove azuldownload and curldownload feature flags (#4734)

* feat: remove azuldownload and curldownload feature flags (#4733)

Remove the AZUL_DOWNLOAD and CURL_DOWNLOAD feature flags so download
features are enabled unconditionally. The NRES consent group check for
curl download is preserved as it is business logic, not a feature gate.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: update e2e test to expect download column visible by default (#4733)

The files tab now shows the download column without a feature flag,
so set emptyFirstColumn to true to account for the extra columnheader.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Fran McDade <18710366+frano-m@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: frano-m

app/components/Export/components/AnVILExplorer/CurlDownload/curlDownloadExportMethod.tsx

@@ -55,7 +55,6 @@ export { ManifestDownloadEntity } from "@databiosphere/findable-ui/lib/component
 export { ManifestDownloadForm } from "@databiosphere/findable-ui/lib/components/Export/components/ManifestDownload/components/ManifestDownloadForm/manifestDownloadForm";
 export { ManifestDownload } from "@databiosphere/findable-ui/lib/components/Export/components/ManifestDownload/manifestDownload";
 export { AzulFileDownload } from "@databiosphere/findable-ui/lib/components/Index/components/AzulFileDownload/azulFileDownload";
-export { AzulFileDownload as AzulFileDownloadVisibilityController } from "./Index/components/AzulFileDownload/azulFileDownload";
 export {
   BackPageContentMainColumn,
   BackPageContentSideColumn,

app/components/Index/components/AzulFileDownload/azulFileDownload.tsx

@@ -2,7 +2,5 @@
  * Set of possible feature flags.
  */
 export enum FEATURES {
-  AZUL_DOWNLOAD = "azuldownload",
-  CURL_DOWNLOAD = "curldownload",
   NCPI_EXPORT = "ncpiexport",
 }

app/components/index.tsx

@@ -162,7 +162,7 @@ export const ANVIL_TABS: AnvilCMGTabCollection = {
     url: "/donors",
   },
   FILES: {
-    emptyFirstColumn: false,
+    emptyFirstColumn: true,
     indexExportPage: ANVIL_INDEX_EXPORT_BUTTONS,
     maxPages: 25,
     preselectedColumns: ANVIL_FILES_PRESELECTED_COLUMNS_BY_NAME,

app/shared/entities.ts

@@ -34,6 +34,7 @@ import { useFeatureFlag } from "@databiosphere/findable-ui/lib/hooks/useFeatureF
 import { FEATURES } from "../../app/shared/entities";
 import NextError from "next/error";
 import { ROUTES } from "../../site-config/anvil-cmg/dev/export/routes";
+
 import { getConsentGroup } from "../../app/apis/azul/anvil-cmg/common/transformers";
 import { DatasetsResponse } from "../../app/apis/azul/anvil-cmg/common/responses";
 
@@ -71,17 +72,14 @@ const EntityDetailPage = (props: EntityDetailPageProps): JSX.Element => {
   const { config: siteConfig } = useConfig();
   const isAnVIL = siteConfig.appTitle?.includes("AnVIL");
   const isNCPIExportEnabled = useFeatureFlag(FEATURES.NCPI_EXPORT);
-  const isCurlDownloadEnabled = useFeatureFlag(FEATURES.CURL_DOWNLOAD);
   const { query } = useRouter();
   if (!props.entityListType) return <></>;
   if (props.override) return <EntityGuard override={props.override} />;
   if (!isNCPIExportEnabled && isNCPIExportRoute(query))
     return <NextError statusCode={404} />;
-  // Curl download requires feature flag AND NRES consent group (AnVIL only)
-  if (isAnVIL && isCurlDownloadRoute(query)) {
-    if (!isCurlDownloadEnabled || !isNRESDataset(props.data)) {
-      return <NextError statusCode={404} />;
-    }
+  // Curl download requires NRES consent group (AnVIL only)
+  if (isAnVIL && isCurlDownloadRoute(query) && !isNRESDataset(props.data)) {
+    return <NextError statusCode={404} />;
   }
   if (isChooseExportView(query)) return <EntityExportView {...props} />;
   if (isExportMethodView(query)) return <EntityExportMethodView {...props} />;

e2e/anvil/anvil-tabs.ts

@@ -1,10 +1,6 @@
 import { JSX } from "react";
 import { ExportMethodView } from "@databiosphere/findable-ui/lib/views/ExportMethodView/exportMethodView";
-import { useConfig } from "@databiosphere/findable-ui/lib/hooks/useConfig";
-import { useFeatureFlag } from "@databiosphere/findable-ui/lib/hooks/useFeatureFlag/useFeatureFlag";
 import { GetStaticProps } from "next";
-import NextError from "next/error";
-import { FEATURES } from "../../app/shared/entities";
 
 export const getStaticProps: GetStaticProps = async () => {
   return {
@@ -19,11 +15,6 @@ export const getStaticProps: GetStaticProps = async () => {
  * @returns download curl command view component.
  */
 const GetCurlCommandPage = (): JSX.Element => {
-  const { config } = useConfig();
-  const isAnVIL = config.appTitle?.includes("AnVIL");
-  const isEnabled = useFeatureFlag(FEATURES.CURL_DOWNLOAD);
-  // Feature flag only applies to AnVIL sites
-  if (isAnVIL && !isEnabled) return <NextError statusCode={404} />;
   return <ExportMethodView />;
 };
 

pages/[entityListType]/[...params].tsx

@@ -8,7 +8,6 @@ import * as C from "../../../../../../app/components";
 import { DatasetsResponse } from "app/apis/azul/anvil-cmg/common/responses";
 import { ROUTES } from "../../../export/routes";
 import * as MDX from "../../../../../../app/components/common/MDXContent/anvil-cmg";
-import { CurlDownloadExportMethod } from "../../../../../../app/components/Export/components/AnVILExplorer/CurlDownload/curlDownloadExportMethod";
 import { ExportMethod } from "../../../../../../app/components/Export/components/AnVILExplorer/platform/ExportMethod/exportMethod";
 import { EXPORT_METHODS, EXPORTS } from "../../../export/constants";
 import { ExportToPlatform } from "../../../../../../app/components/Export/components/AnVILExplorer/platform/ExportToPlatform/exportToPlatform";
@@ -381,9 +380,9 @@ export const exportConfig: ExportConfig = {
                 {
                   children: [
                     {
-                      component: CurlDownloadExportMethod,
+                      component: C.ExportMethod,
                       viewBuilder: V.buildDatasetExportMethodCurlCommand,
-                    } as ComponentConfig<typeof CurlDownloadExportMethod>,
+                    } as ComponentConfig<typeof C.ExportMethod>,
                   ],
                   component: C.ConditionalComponent,
                   viewBuilder: V.renderDatasetCurlDownload,

pages/export/get-curl-command.tsx

@@ -8,7 +8,6 @@ import { ROUTES } from "./routes";
 import { mainColumn as exportMainColumn } from "./exportMainColumn";
 import { sideColumn as exportSideColumn } from "./exportSideColumn";
 import { ExportMethod } from "../../../../app/components/Export/components/AnVILExplorer/platform/ExportMethod/exportMethod";
-import { CurlDownloadExportMethod } from "../../../../app/components/Export/components/AnVILExplorer/CurlDownload/curlDownloadExportMethod";
 import { EXPORT_METHODS, EXPORTS } from "./constants";
 
 export const exportConfig: ExportConfig = {
@@ -181,9 +180,9 @@ export const exportConfig: ExportConfig = {
         {
           children: [
             {
-              component: CurlDownloadExportMethod,
+              component: C.ExportMethod,
               viewBuilder: V.buildExportMethodBulkDownload,
-            } as ComponentConfig<typeof CurlDownloadExportMethod>,
+            } as ComponentConfig<typeof C.ExportMethod>,
             {
               component: C.ExportMethod,
               viewBuilder: V.buildExportMethodTerra,

site-config/anvil-cmg/dev/detail/dataset/export/export.ts

@@ -150,7 +150,6 @@ export const filesEntityConfig: EntityConfig<FilesResponse> = {
     tableOptions: {
       initialState: {
         columnVisibility: {
-          [ANVIL_CMG_CATEGORY_KEY.AZUL_FILE_DOWNLOAD]: false,
           [ANVIL_CMG_CATEGORY_KEY.DONOR_PHENOTYPIC_SEX]: false,
           [ANVIL_CMG_CATEGORY_KEY.DONOR_REPORTED_ETHNICITY]: false,
           [ANVIL_CMG_CATEGORY_KEY.DIAGNOSE_DISEASE]: false,