fix: fix flaky deselect filters e2e test (#4751) (#4753)

* fix: fix flaky deselect filters e2e test (#4751)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: wait for checkbox checked state after click instead of filter tag (#4751)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Fran McDade <18710366+frano-m@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: frano-m

e2e/testFunctions.ts

@@ -779,6 +779,8 @@ export async function testDeselectFiltersThroughSearchBar(
       firstFilterOptionLocator
     );
     await firstFilterOptionLocator.click();
+    // Wait for the checkbox to be checked, confirming the filter state update completed.
+    await expect(firstFilterOptionLocator.getByRole("checkbox")).toBeChecked();
     await page.waitForLoadState("load");
     await page.locator("body").click();
     // Search for and check the selected filter