Merge pull request #234 from DIMO-Network/feature/modify_segment_defaults

Updating defaults

Author: zer0stars

internal/graph/generated.go

@@ -52,14 +52,14 @@ func validateSegmentConfig(config *model.SegmentConfig) error {
 	}
 
 	if config.MinSegmentDurationSeconds != nil {
-		if *config.MinSegmentDurationSeconds < 1 || *config.MinSegmentDurationSeconds > 3600 {
-			return fmt.Errorf("minSegmentDurationSeconds must be between 1 and 3600")
+		if *config.MinSegmentDurationSeconds < 60 || *config.MinSegmentDurationSeconds > 3600 {
+			return fmt.Errorf("minSegmentDurationSeconds must be between 60 and 3600")
 		}
 	}
 
 	if config.SignalCountThreshold != nil {
-		if *config.SignalCountThreshold < 3 || *config.SignalCountThreshold > 100 {
-			return fmt.Errorf("signalCountThreshold must be between 3 and 100")
+		if *config.SignalCountThreshold < 1 || *config.SignalCountThreshold > 3600 {
+			return fmt.Errorf("signalCountThreshold must be between 1 and 3600")
 		}
 	}
 

internal/graph/model/models_gen.go

@@ -14,7 +14,7 @@ const (
 	defaultCUSUMThreshold                    = 5.0 // CUSUM threshold for detecting change points
 	defaultCUSUMDrift                        = 0.5 // Drift parameter (half of expected change magnitude)
 	defaultCUSUMBaselineSignalCount          = 1.0 // Baseline signal count per window when idle
-	defaultCUSUMSignalCountThreshold         = 12  // Minimum signals per window for activity
+	defaultCUSUMSignalCountThreshold         = 10  // Minimum signals per window for activity
 	defaultCUSUMDistinctSignalCountThreshold = 2   // Minimum distinct signal types per window
 )
 

internal/repositories/segments.go

@@ -11,7 +11,7 @@ import (
 
 const (
 	defaultWindowSizeSeconds            = 60 // 1 minute windows
-	defaultSignalCountThreshold         = 12 // Minimum signals per window for activity
+	defaultSignalCountThreshold         = 10 // Minimum signals per window for activity
 	defaultDistinctSignalCountThreshold = 2  // Minimum distinct signal types per window
 )
 

internal/service/ch/changepoint_detector.go

@@ -10,8 +10,8 @@ import (
 )
 
 const (
-	defaultMinIdleSeconds            = 600 // 5 minutes
-	defaultMinSegmentDurationSeconds = 150 // 5 minutes
+	defaultMinIdleSeconds            = 300 // 5 minutes
+	defaultMinSegmentDurationSeconds = 240 // 4 minutes
 )
 
 // IgnitionDetector detects segments using ignition state transitions

internal/service/ch/frequency_detector.go

@@ -55,16 +55,16 @@ input SegmentConfig {
   """
   Minimum segment duration (seconds) to include in results.
   Filters very short segments (testing, engine cycling).
-  Default: 60 (1 minute), Min: 1, Max: 3600
+  Default: 240 (4 minutes), Min: 60, Max: 3600
   """
-  minSegmentDurationSeconds: Int = 60
+  minSegmentDurationSeconds: Int = 240
 
   """
   [frequencyAnalysis only] Minimum signal count per window for activity detection.
   Higher values = more conservative (filters parked telemetry better).
   Lower values = more sensitive (works for sparse signal vehicles).
   Default: 10 (tuned to match ignition detection accuracy)
-  Min: 3, Max: 100
+  Min: 1, Max: 3600
   """
   signalCountThreshold: Int = 10
 }