From bb0b4e44b1a1d5cca80f455177a18cd8839242b6 Mon Sep 17 00:00:00 2001
From: Henrik Andersson <jan@dhigroup.com>
Date: Wed, 28 Jan 2026 21:02:37 +0100
Subject: [PATCH] Remove dead None checks from taylor plot methods

skill() and mean_skill() always return SkillTable, never None.
---
 src/modelskill/comparison/_collection_plotter.py | 6 +-----
 src/modelskill/comparison/_comparer_plotter.py   | 3 ---
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/modelskill/comparison/_collection_plotter.py b/src/modelskill/comparison/_collection_plotter.py
index 2122b8488..d720ed595 100644
--- a/src/modelskill/comparison/_collection_plotter.py
+++ b/src/modelskill/comparison/_collection_plotter.py
@@ -464,7 +464,7 @@ def taylor(
         marker: str = "o",
         marker_size: float = 6.0,
         title: str = "Taylor diagram",
-    ) -> Optional[Figure]:
+    ) -> Figure:
         """Taylor diagram for model skill comparison.
 
         Taylor diagram showing model std and correlation to observation
@@ -510,10 +510,6 @@ def taylor(
         sk = skill_func(
             metrics=[mtr._std_obs, mtr._std_mod, mtr.cc],  # type: ignore
         )
-        if sk is None:
-            # TODO when does this make sense?
-            return
-
         # TODO reduce duplication of code in the ComparerPlotter/ComparerCollectionPlotter
         df = sk.to_dataframe()
         ref_std = 1.0 if normalize_std else df.iloc[0]["_std_obs"]
diff --git a/src/modelskill/comparison/_comparer_plotter.py b/src/modelskill/comparison/_comparer_plotter.py
index 5467eafc2..114370360 100644
--- a/src/modelskill/comparison/_comparer_plotter.py
+++ b/src/modelskill/comparison/_comparer_plotter.py
@@ -734,9 +734,6 @@ def taylor(
         ]
 
         sk = cmp.skill(metrics=metrics)
-
-        if sk is None:  # TODO
-            return
         df = sk.to_dataframe().reset_index()
         if "model" not in df.columns:
             # doesn't make sense to make a taylor plot...