Skip to content

Commit 7367f18

Browse files
committed
refactor: enhance floor display format
1 parent 000238a commit 7367f18

5 files changed

Lines changed: 23 additions & 16 deletions

File tree

example/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,15 @@
55
"license": "MIT",
66
"private": true,
77
"dependencies": {
8-
"antd": "^3.12.1",
8+
"antd": "^3.15.0",
99
"classnames": "^2.2.6",
1010
"dva": "^2.4.1",
1111
"fengmap": "^2.2.0",
1212
"lodash": "^4.17.11",
1313
"path-to-regexp": "^2.4.0",
14-
"react": "^16.7.0",
15-
"react-syntax-highlighter": "^10.1.2",
16-
"react-dom": "^16.7.0",
14+
"react": "^16.8.4",
15+
"react-syntax-highlighter": "^10.2.0",
16+
"react-dom": "^16.8.4",
1717
"react-fengmap": "file:.."
1818
},
1919
"scripts": {
@@ -23,9 +23,9 @@
2323
"devDependencies": {
2424
"babel-eslint": "^9.0.0",
2525
"less-vars-to-js": "^1.3.0",
26-
"prettier": "^1.15.3",
26+
"prettier": "^1.16.4",
2727
"redbox-react": "^1.6.0",
28-
"umi": "^2.4.2",
29-
"umi-plugin-react": "^1.4.0"
28+
"umi": "^2.6.1",
29+
"umi-plugin-react": "^1.6.0"
3030
}
3131
}

example/src/pages/api/fengmap-floorcontrol/index.js

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class FengmapFloorControlDoc extends Component {
2121
<Highlight language="jsx">
2222
{`// 只能配合基础地图
2323
<FengmapBase mapId={MapId} style={Style} fengmapSDK={SDK} mapOptions={MapOptions} >
24-
<FengmapFloorControl ctrlOptions={CtrlOptions} onFloorChange={OnFloorChange} />
24+
<FengmapFloorControl ctrlOptions={CtrlOptions} labelFormater={LabelFormater} />
2525
</FengmapBase>
2626
`}
2727
</Highlight>
@@ -47,9 +47,9 @@ class FengmapFloorControlDoc extends Component {
4747
)
4848
},
4949
{
50-
prop: 'onFloorChange',
51-
type: 'Function',
52-
description: '楼层切换时的回调函数'
50+
prop: 'labelFormater',
51+
type: '(floor: Number) => String',
52+
description: '自定义楼层标签'
5353
}
5454
]}
5555
/>
@@ -84,9 +84,7 @@ class FengmapFloorControlDoc extends Component {
8484
position: fengmapSDK.controlPositon.RIGHT_BOTTOM,
8585
showBtnCount: 4
8686
}}
87-
onFloorChange={floor => {
88-
console.log(`Changed floor to: `, floor)
89-
}}
87+
labelFormater={v => v + 'F'}
9088
/>
9189
</FengmapBase>
9290

@@ -123,7 +121,7 @@ export default function Example(props) {
123121
position: fengmapSDK.controlPositon.RIGHT_BOTTOM,
124122
showBtnCount: 7
125123
}}
126-
onFloorChange={props.changeFloor}
124+
labelFormater={v => v + 'F'}
127125
/>
128126
</FengmapBase>
129127
)

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-fengmap",
3-
"version": "2.7.6",
3+
"version": "2.7.7",
44
"description": "",
55
"author": "leftstick",
66
"typings": "typings/index.d.ts",

src/components/HorizontalButtonGroupsControl/index.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,11 @@ class HorizontalButtonGroupsControl extends React.Component {
127127

128128
_getFloorName = floorLevel => {
129129
const { labelFormater } = this.props
130+
131+
if (!floorLevel || Number.isNaN(floorLevel)) {
132+
return ''
133+
}
134+
130135
if (labelFormater) {
131136
return `${labelFormater(floorLevel)}`
132137
}

src/components/VerticalButtonGroupsControl/index.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,10 @@ class VerticalButtonGroupsControl extends React.Component {
125125

126126
_getFloorName = floorLevel => {
127127
const { labelFormater } = this.props
128+
if (!floorLevel || Number.isNaN(floorLevel)) {
129+
return ''
130+
}
131+
128132
if (labelFormater) {
129133
return `${labelFormater(floorLevel)}`
130134
}

0 commit comments

Comments
 (0)