You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 20, 2025. It is now read-only.
Describe the feature or improvement you're requesting
It would be great if you could add proper support for the compilation of the library as DLL on Windows via the BUILD_SHARED_LIBS CMake variable. Currently the __declspec(dllexport) attribute is applied to many methods in the codebase. If there is no intention to support DLL compilation, please remove the __declspec(dllexport) attribute since it is not required for static libraries. I would even consider this an error as it is applied now. To support DLL compilation, something like this has to be implemented:
Describe the feature or improvement you're requesting
It would be great if you could add proper support for the compilation of the library as DLL on Windows via the BUILD_SHARED_LIBS CMake variable. Currently the __declspec(dllexport) attribute is applied to many methods in the codebase. If there is no intention to support DLL compilation, please remove the __declspec(dllexport) attribute since it is not required for static libraries. I would even consider this an error as it is applied now. To support DLL compilation, something like this has to be implemented:
liboai\include\core\response.h:
liboai\CMakeLists.txt:
Furthermore, the
LIBOAI_EXPORTmacro has to be applied to all methods that are used by a client.Additional context
No response