Use shorthand notation when setting default values

Author: Cyclonecode

scripts/db.js

@@ -3,10 +3,10 @@ const mysql = require('mysql')
 const argv = require('minimist')(process.argv.slice(2))
 const sprintf = require('sprintf-js').sprintf
 
-const MYSQL_USERNAME = argv.user ? argv.user : 'root'
-const MYSQL_PASSWORD = argv.pass ? argv.pass : ''
-const MYSQL_DATABASE = argv.database ? argv.database : 'mysql_note'
-const MYSQL_HOSTNAME = argv.host ? argv.host : 'localhost'
+const MYSQL_USERNAME = argv.user || 'root'
+const MYSQL_PASSWORD = argv.pass || ''
+const MYSQL_DATABASE = argv.database || 'mysql_note'
+const MYSQL_HOSTNAME = argv.host || 'localhost'
 const MYSQL_PORT = argv.port ? parseInt(argv.port) : 3306
 
 const con = mysql.createConnection({
@@ -17,9 +17,8 @@ const con = mysql.createConnection({
   port: MYSQL_PORT
 })
 
-module.exports =
-{
+module.exports = {
   argv: argv,
   sprintf: sprintf,
   con: con
-}
+}

scripts/delete.js

@@ -5,15 +5,15 @@ const id = db.argv.id || parseInt(db.argv.id)
 
 db.con.connect(function(err) {
   if (err) {
-    console.log('Failed to connect')
+    console.error('Failed to connect')
     throw err
   }
   let sql = 'DELETE FROM post' + (id ? ' WHERE id = ' + id : '')
   db.con.query(sql, (err, result) => {
     if (err) {
       throw err
     }
-    console.log('Removed ' + result.affectedRows + ' record(s)')
+    console.info('Removed ' + result.affectedRows + ' record(s)')
     process.exit(0)
   })
 })

scripts/insert.js

@@ -1,21 +1,21 @@
 #!/usr/bin/env node
 const db = require('./db')
 
-const title = db.argv.title ? db.argv.title : ''
-const content = db.argv.content ? db.argv.content : ''
-const image = db.argv.image ? db.argv.image : ''
+const title = db.argv.title || ''
+const content = db.argv.content || ''
+const image = db.argv.image || ''
 
 db.con.connect(function(err) {
   if (err) {
-    console.log('Failed to connect')
+    console.error('Failed to connect')
     throw err
   }
   let sql = db.sprintf("INSERT INTO post VALUES(NULL, '%s', '%s', '%s')", title, content, image)
   db.con.query(sql, (err, result) => {
     if (err) {
       throw err
     }
-    console.log('Inserted ' + result.affectedRows + ' record(s)')
+    console.info('Inserted ' + result.affectedRows + ' record(s)')
     process.exit(0)
   })
 })

scripts/select.js

@@ -5,7 +5,7 @@ const id = db.argv.id || parseInt(db.argv.id)
 
 db.con.connect(function(err) {
   if (err) {
-    console.log('Failed to connect')
+    console.error('Failed to connect')
     throw err
   }
   let sql = 'SELECT * FROM post'
@@ -17,7 +17,7 @@ db.con.connect(function(err) {
       throw err
     }
     for (let i = 0; i < result.length; i++) {
-      console.log(result[i])
+      console.info(result[i])
     }
     process.exit(0)
   })

scripts/update.js

@@ -15,7 +15,7 @@ if (!title && !content && !image) {
 
 db.con.connect(function(err) {
   if (err) {
-    console.log('Failed to connect')
+    console.error('Failed to connect')
     throw err
   }
   let sql = 'UPDATE post SET '
@@ -34,7 +34,7 @@ db.con.connect(function(err) {
     if (err) {
       throw err
     }
-    console.log('Updated ' + result.affectedRows + ' record(s)')
+    console.info('Updated ' + result.affectedRows + ' record(s)')
     process.exit(0)
   })
 })