Fix page scroll while dialog open

Author: christianezeani

projects/ngsuite/src/lib/dialog/services/Dialog.ts

@@ -57,19 +57,20 @@ export class NGSuiteDialog {
       'add "<ngs-dialog-root></ngs-dialog-root>" to your root component to enable the NGSuiteDialog feature.'
     );
 
+    const onClosed = (ins: NGSuiteDialogInstance) => {
+      this.registry.remove(ins);
+    }
+
     const instance = new NGSuiteDialogInstance(
       root.viewContainerRef,
       component,
       root.injector,
+      onClosed,
       config
     );
 
     this.registry.add(instance);
 
-    instance.afterClosed.subscribe(() => {
-      this.registry.remove(instance);
-    });
-
     return instance;
   }
 

projects/ngsuite/src/lib/dialog/services/DialogInstance.ts

@@ -5,6 +5,8 @@ import { NGSuiteDialogComponent } from "../components/dialog/dialog.component";
 import { NGSuiteDialogCommand, NGSuiteDialogConfig, NGS_DIALOG_CONFIG, NGS_DIALOG_CONTENT } from "../interfaces/Dialog";
 import { NGSuiteDialogRef } from "./DialogRef";
 
+type OnClosedFn = (ins: NGSuiteDialogInstance) => void;
+
 export class NGSuiteDialogInstance {
 
   private xDialogComponentRef: ComponentRef<NGSuiteDialogComponent> = null as any;
@@ -20,6 +22,7 @@ export class NGSuiteDialogInstance {
     private xViewContainerRef: ViewContainerRef,
     private component: NGSuiteComponent<any>,
     private injector: Injector,
+    private onClosed: OnClosedFn,
     private config?: NGSuiteDialogConfig
   ) {
     this.command = new Observable<NGSuiteDialogCommand<any>>(subscriber => {
@@ -78,6 +81,8 @@ export class NGSuiteDialogInstance {
     const { xAfterClosedSubscriber } = this;
     xAfterClosedSubscriber.next(data);
     xAfterClosedSubscriber.complete();
+
+    this.onClosed(this);
   }
 
   send(cmd: NGSuiteDialogCommand<any>) {

projects/ngsuite/src/lib/dialog/services/DialogRegistry.ts

@@ -30,6 +30,11 @@ export class NGSuiteDialogRegistry {
 
   private readonly cloneList = () => Array.from(this.list());
 
+  private readonly indexOf = (item: NGSuiteDialogInstance) => {
+    const entries = this.list();
+    return entries.indexOf(item);
+  }
+
   readonly active = () => {
     const entries = this.cloneList();
     if (!entries.length) return null;
@@ -54,7 +59,7 @@ export class NGSuiteDialogRegistry {
   readonly remove = (item: NGSuiteDialogInstance) => {
     const entries = this.cloneList();
 
-    const index = entries.indexOf(item);
+    const index = this.indexOf(item);
     entries.splice(index, 1);
 
     this.list.set(entries);