[STAGING] FAC-122.1 to FAC-123.2 fix schema drift (#311)

* FAC-122.1 chore: add @Index expression metadata for soft-delete partial indexes (#308)

* FAC-122.2 fix: explicitly type CustomBaseEntity.deletedAt to fix varchar(255) reflection (#309)

TypeScript's emitDecoratorMetadata can't reflect optional Date types without
initializers, causing MikroORM to fall back to varchar(255). This adds explicit
type: 'datetime' to the deletedAt decorator and includes a migration to convert
29 affected tables from varchar(255) to timestamptz.

Closes #306

* FAC-122.3 fix: resolve MikroORM migration drift for audit_log, recommended_action, and playing_with_neon (#310)

- Add defaultRaw: 'now()' and length: 6 to AuditLog.occurredAt entity
- Add Opt type annotation and app-level default to match codebase pattern
- Update snapshot to align audit_log.occurred_at.default with entity
- Fix Migration20260412153923 to drop/recreate matviews before altering deleted_at columns
- Clean Migration20260412161915 to remove redundant deleted_at statements
- Add SET DEFAULT now() to audit_log.occurred_at in migration UP

Verified: npx mikro-orm migration:check exits 0, all 885 tests pass

Author: y4nder

src/entities/audit-log.entity.ts

@@ -39,6 +39,6 @@ export class AuditLog {
   ipAddress?: string;
 
   @Index()
-  @Property()
-  occurredAt!: Date;
+  @Property({ defaultRaw: 'now()', length: 6 })
+  occurredAt: Date & Opt = new Date();
 }

src/entities/base.entity.ts

@@ -11,7 +11,7 @@ export abstract class CustomBaseEntity {
   @Property()
   updatedAt: Date & Opt = new Date();
 
-  @Property({ nullable: true })
+  @Property({ type: 'datetime', nullable: true })
   deletedAt?: Date & Opt;
 
   SoftDelete() {

src/entities/questionnaire-type.entity.ts

@@ -2,6 +2,11 @@ import { Entity, Property, Index } from '@mikro-orm/core';
 import { CustomBaseEntity } from './base.entity';
 import { QuestionnaireTypeRepository } from '../repositories/questionnaire-type.repository';
 
+@Index({
+  name: 'questionnaire_type_code_unique',
+  expression:
+    'create unique index "questionnaire_type_code_unique" on "questionnaire_type" ("code") where "deleted_at" is null',
+})
 @Entity({ repository: () => QuestionnaireTypeRepository })
 export class QuestionnaireType extends CustomBaseEntity {
   @Property()

src/entities/report-job.entity.ts

@@ -10,6 +10,19 @@ export type ReportJobStatus =
   | 'failed'
   | 'skipped';
 
+@Index({
+  name: 'uq_report_job_pending',
+  expression: `create unique index "uq_report_job_pending" on "report_job" ("faculty_id", "semester_id", "questionnaire_type_code", "report_type") where status in ('waiting', 'active') and deleted_at is null`,
+})
+@Index({
+  name: 'report_job_batch_id_index',
+  expression:
+    'create index "report_job_batch_id_index" on "report_job" ("batch_id") where batch_id is not null',
+})
+@Index({
+  name: 'report_job_status_completed_at_index',
+  properties: ['status', 'completedAt'],
+})
 @Entity({ repository: () => ReportJobRepository })
 export class ReportJob extends CustomBaseEntity {
   @Property()
@@ -36,7 +49,7 @@ export class ReportJob extends CustomBaseEntity {
   questionnaireTypeCode: string;
 
   @Property({ nullable: true })
-  @Index()
+  // Indexed via class-level @Index (name: 'report_job_batch_id_index') — see top of file
   batchId?: string;
 
   @Property({ nullable: true })

src/entities/sentiment-result.entity.ts

@@ -4,6 +4,16 @@ import { SentimentResultRepository } from '../repositories/sentiment-result.repo
 import { SentimentRun } from './sentiment-run.entity';
 import { QuestionnaireSubmission } from './questionnaire-submission.entity';
 
+@Index({
+  name: 'idx_sr_submission_processed',
+  expression:
+    'create index "idx_sr_submission_processed" on "sentiment_result" ("submission_id", "processed_at" desc) where "deleted_at" is null',
+})
+@Index({
+  name: 'sentiment_result_run_id_submission_id_unique',
+  expression:
+    'create unique index "sentiment_result_run_id_submission_id_unique" on "sentiment_result" ("run_id", "submission_id") where "deleted_at" is null',
+})
 @Entity({ repository: () => SentimentResultRepository })
 @Index({ properties: ['run'] })
 @Index({ properties: ['submission'] })

src/entities/submission-embedding.entity.ts

@@ -4,6 +4,11 @@ import { CustomBaseEntity } from './base.entity';
 import { QuestionnaireSubmission } from './questionnaire-submission.entity';
 import { SubmissionEmbeddingRepository } from '../repositories/submission-embedding.repository';
 
+@Index({
+  name: 'submission_embedding_submission_id_unique',
+  expression:
+    'create unique index "submission_embedding_submission_id_unique" on "submission_embedding" ("submission_id") where "deleted_at" is null',
+})
 @Entity({ repository: () => SubmissionEmbeddingRepository })
 @Index({ properties: ['submission'] })
 export class SubmissionEmbedding extends CustomBaseEntity {

src/entities/topic-assignment.entity.ts

@@ -4,6 +4,11 @@ import { TopicAssignmentRepository } from '../repositories/topic-assignment.repo
 import { Topic } from './topic.entity';
 import { QuestionnaireSubmission } from './questionnaire-submission.entity';
 
+@Index({
+  name: 'topic_assignment_topic_id_submission_id_unique',
+  expression:
+    'create unique index "topic_assignment_topic_id_submission_id_unique" on "topic_assignment" ("topic_id", "submission_id") where "deleted_at" is null',
+})
 @Entity({ repository: () => TopicAssignmentRepository })
 @Index({ properties: ['topic'] })
 @Index({ properties: ['submission'] })