PR Fixes

Author: Crustack

app/src/main/java/com/philkes/notallyx/presentation/activity/main/fragment/settings/PreferenceBindingExtensions.kt

@@ -542,7 +542,6 @@ fun PreferenceSeekbarBinding.setupTextSizePreference(
 
                 override fun onStopTrackingTouch(slider: Slider) {
                     PreviewText.isVisible = false
-                    onChange(slider.value)
                 }
             }
         )

app/src/main/java/com/philkes/notallyx/presentation/view/note/listitem/adapter/CheckedListItemAdapter.kt

@@ -10,10 +10,11 @@ import com.philkes.notallyx.data.model.NoteViewMode
 import com.philkes.notallyx.presentation.view.note.listitem.HighlightText
 import com.philkes.notallyx.presentation.view.note.listitem.ListManager
 import com.philkes.notallyx.presentation.viewmodel.preference.NotallyXPreferences
+import com.philkes.notallyx.presentation.viewmodel.preference.TextSizeSp
 
 class CheckedListItemAdapter(
     @ColorInt var backgroundColor: Int,
-    private val textSize: Int,
+    private val textSize: TextSizeSp,
     elevation: Float,
     private val preferences: NotallyXPreferences,
     private val listManager: ListManager,

app/src/main/java/com/philkes/notallyx/presentation/view/note/listitem/adapter/ListItemAdapter.kt

@@ -11,10 +11,11 @@ import com.philkes.notallyx.data.model.NoteViewMode
 import com.philkes.notallyx.presentation.view.note.listitem.HighlightText
 import com.philkes.notallyx.presentation.view.note.listitem.ListManager
 import com.philkes.notallyx.presentation.viewmodel.preference.NotallyXPreferences
+import com.philkes.notallyx.presentation.viewmodel.preference.TextSizeSp
 
 class ListItemAdapter(
     @ColorInt var backgroundColor: Int,
-    private val textSize: Int,
+    private val textSize: TextSizeSp,
     elevation: Float,
     private val preferences: NotallyXPreferences,
     private val listManager: ListManager,

app/src/main/java/com/philkes/notallyx/presentation/view/note/listitem/adapter/ListItemAdapterBase.kt

@@ -12,6 +12,7 @@ import com.philkes.notallyx.databinding.RecyclerListItemBinding
 import com.philkes.notallyx.presentation.view.note.listitem.ListItemDragCallback
 import com.philkes.notallyx.presentation.view.note.listitem.ListManager
 import com.philkes.notallyx.presentation.viewmodel.preference.NotallyXPreferences
+import com.philkes.notallyx.presentation.viewmodel.preference.TextSizeSp
 
 data class ListItemHighlight(
     val itemPos: Int,
@@ -24,7 +25,7 @@ data class ListItemHighlight(
 abstract class ListItemAdapterBase(
     private val adapter: RecyclerView.Adapter<*>,
     @ColorInt var backgroundColor: Int,
-    private val textSize: Int,
+    private val textSize: TextSizeSp,
     elevation: Float,
     private val preferences: NotallyXPreferences,
     private val listManager: ListManager,

app/src/main/java/com/philkes/notallyx/presentation/view/note/listitem/adapter/ListItemVH.kt

@@ -40,7 +40,7 @@ class ListItemVH(
     val binding: RecyclerListItemBinding,
     val listManager: ListManager,
     touchHelper: ItemTouchHelper,
-    textSize: Int,
+    textSize: Float,
     private val inCheckedList: Boolean,
 ) : RecyclerView.ViewHolder(binding.root) {
 

app/src/main/java/com/philkes/notallyx/presentation/viewmodel/NotallyModel.kt

@@ -39,6 +39,7 @@ import com.philkes.notallyx.presentation.showToast
 import com.philkes.notallyx.presentation.view.misc.NotNullLiveData
 import com.philkes.notallyx.presentation.view.misc.Progress
 import com.philkes.notallyx.presentation.viewmodel.preference.NotallyXPreferences
+import com.philkes.notallyx.presentation.viewmodel.preference.TextSizeSp
 import com.philkes.notallyx.presentation.viewmodel.progress.AddFilesProgress
 import com.philkes.notallyx.presentation.widget.WidgetProvider
 import com.philkes.notallyx.utils.Cache
@@ -68,7 +69,7 @@ class NotallyModel(private val app: Application) : AndroidViewModel(app) {
     private lateinit var baseNoteDao: BaseNoteDao
 
     val preferences = NotallyXPreferences.getInstance(app)
-    val textSize = preferences.textSizeNoteEditor.value
+    val textSize: TextSizeSp = preferences.textSizeNoteEditor.value
 
     var isNewNote = true
 

app/src/main/res/layout/recycler_base_note.xml

@@ -125,7 +125,6 @@
             <com.google.android.material.chip.Chip
                 android:id="@+id/ReminderChip"
                 style="@style/ReminderChip"
-                android:layout_marginStart="12dp"
                 tools:closeIconVisible="true"
                 tools:text="00/00/0000 00:00"
                 tools:visibility="visible"

app/src/main/res/values-cs/strings.xml

@@ -319,7 +319,7 @@
     <string name="tap_for_more_options">Klepněte pro více možností</string>
     <string name="tap_to_set_up">Nastavit klepnutím sem</string>
     <string name="text_default">Výchozí</string>
-    <string name="text_size_note_editor">Velikost písma</string>
+    <string name="text_size_note_editor">Velikost písma (editor poznámek)</string>
     <string name="theme">Téma</string>
     <string name="theme_use_dynamic_colors">Použít barvy z tapety</string>
     <string name="title">Název</string>
@@ -350,4 +350,5 @@
     <string name="yearly">Ročně</string>
     <string name="years">Roky</string>
     <string name="your_notes_associated">Vaše poznámky přiřazené k tomuto štítku nebudou smazány</string>
+    <string name="text_size_overview">Velikost písma (přehled)</string>
 </resources>

app/src/main/res/values-de/strings.xml

@@ -339,7 +339,7 @@
     <string name="tap_for_more_options">Klick für mehr Optionen</string>
     <string name="tap_to_set_up">Zum Einrichten antippen</string>
     <string name="text_default">Standard</string>
-    <string name="text_size_note_editor">Textgröße</string>
+    <string name="text_size_note_editor">Textgröße (Notizeditor)</string>
     <string name="theme">Design</string>
     <string name="theme_use_dynamic_colors">Systemhintergrundfarben verwenden</string>
     <string name="title">Titel</string>
@@ -369,4 +369,5 @@
     <string name="yearly">Jährlich</string>
     <string name="years">Jahre</string>
     <string name="your_notes_associated">Notizen, welche dieses Label verwenden, werden nicht gelöscht.</string>
+    <string name="text_size_overview">Textgröße (Übersicht)</string>
 </resources>

app/src/main/res/values-es/strings.xml

@@ -312,7 +312,7 @@
     <string name="tap_for_more_options">Tocar para más opciones</string>
     <string name="tap_to_set_up">Toque para configurar</string>
     <string name="text_default">Por defecto</string>
-    <string name="text_size_note_editor">Tamaño de texto</string>
+    <string name="text_size_note_editor">Tamaño de texto (editor de notas)</string>
     <string name="theme">Tema</string>
     <string name="theme_use_dynamic_colors">Usar color de fondo del sistema</string>
     <string name="title">Título</string>
@@ -342,4 +342,5 @@
     <string name="yearly">Anual</string>
     <string name="years">Años</string>
     <string name="your_notes_associated">Tus notas asociadas con esta etiqueta no serán eliminadas</string>
+    <string name="text_size_overview">Tamaño de texto (descripción general)</string>
 </resources>