No test for malformed graph

[GREENRAT-K405]

The current tests for cli only capture two scenarios:

• file is missing or
• file is valid
  it lacks to test the cases where the file does exist but the graphml file has corrupted XML.

I propose adding a corrupted XML test

[GREENRAT-K405]

@pradeeban , what are your thoughts on this? is this required?

I'd like to work on this issue!

[avinxshKD]

@pradeeban , what are your thoughts on this? is this required?

I'd like to work on this issue!

Makes sense ,, I'd suggest we test at least:

1. Broken XML syntax
2. Missing required GraphML attributes
3. Invalid data types in node properties

@pradeeban want me to draft a PR with a few test cases?

[GREENRAT-K405]

@avinxshKD I am already working on this issue. Thanks for offering your help but please work on different issue.

[avinxshKD]

@avinxshKD I am already working on this issue. Thanks for offering your help but please work on different issue.

Just to clarify, I was adding suggestions to the discussion, not claiming the issue. All good, I’ll put up a PR for the test cases I mentioned. If thats okay @pradeeban, thanks

[pradeeban]

It is a dangerous task. There was a PR I closed: #213.
concore supports directed hypergraphs.

If you are simply validating whether a graphml is valid, it should be ok.
But assuming all the graphml files are produced by concore-editor, I believe we won't have invalid graphml files? Just be cautious with this fix. We do not want to unintentionally introduce bugs while trying to fix a problem that does not exist in practice (since this is handled by concore-editor, unless someone mistakenly tries to run a graphml not created by concore-editor, which is unlikely).

[pradeeban]

Closing this since #218 is merged.