Skip to content

Commit 03b36df

Browse files
committed
Base timeline "get_active_effect" does not make sense
1 parent f1fb6cb commit 03b36df

File tree

2 files changed

+5
-14
lines changed

2 files changed

+5
-14
lines changed

demosys/timeline/base.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ class BaseTimeline:
99
def __init__(self, project, *args, **kwargs):
1010
self._project = project
1111

12-
def get_active_effect(self, time):
13-
raise NotImplementedError()
14-
1512
def draw(self, time, frametime, target):
1613
"""
1714
Called by the system every frame.
@@ -25,12 +22,10 @@ def draw(self, time, frametime, target):
2522

2623
def key_event(self, key, action, mods):
2724
"""
28-
Forwarded (unconsumed) key events from the system.
29-
See glfw's key events for detailed information.
25+
Forwarded key events from the system.
3026
31-
:param key: The keyboard key that was pressed or released.
32-
:param scancode: The system-specific scancode of the key.
33-
:param action: GLFW_PRESS, GLFW_RELEASE or GLFW_REPEAT
27+
:param key: The key that was pressed or released.
28+
:param action: ACTION_PRESS, ACTION_RELEASE
3429
:param mods: Bit field describing which modifier keys were held down.
3530
"""
36-
raise NotImplementedError()
31+
pass

demosys/timeline/single.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,9 @@ class Timeline(BaseTimeline):
66
def __init__(self, project, *args, **kwargs):
77
super().__init__(project)
88

9-
def get_active_effect(self, time):
10-
return self._project.get_default_effect()
11-
129
def draw(self, time, frametime, target):
13-
effect = self.get_active_effect(time)
10+
effect = self._project.get_default_effect()
1411
effect.draw(time, frametime, target)
1512

1613
def key_event(self, key, action, mods):
17-
# print("Timeline:key_event", key, action, mods)
1814
pass

0 commit comments

Comments
 (0)