Fix secrets (well it works...) #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosenotduck
requested changes
Dec 6, 2025
Contributor
goosenotduck
left a comment
goosenotduck
left a comment
There was a problem hiding this comment.
This is an awful solution to the problem. Just because the project is already messy doesn't mean we should add equally bad code on top. A JSON environment variable is mega cursed.
In my mind, the proper solution is to add each configuration option as it's own environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move google secrets to be an environment variable to work well with okd deployments.
Also update readme
Why
Jumpstart is broken rn because of okd (see https://jumpstart.csh.rit.edu/)
Test Plan
get environment stuff from okd. Does it boot and calendar stuff works? yes okay cool it's good 👍
Env Vars
yes.
GOOGLE_CLIENT_SECERTS_JSONis the contents of the json file. it's in okd right now as something but I will fixChecklist