Skip via Pre-container-backup script fails when containers are in group

[Zeager0]

It acknowledges the skip in the [group] section but then backs it up anyway under [main]? When not in a group it skips successfully.

fail_backup.log
success_backup.log

[Commifreak]

Could you upload a debug log please?

[Zeager0]

@Commifreak
backup.debug.log
The 2 containers Ganymede and postgresql14 are in group "twitch"

[Commifreak]

Ah, I think I found it, I cant test the fix as I dont have any Unraid here at the moment. Could you adjust ABHelper.php on your side and try again?

Index: src/include/ABHelper.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/include/ABHelper.php b/src/include/ABHelper.php
--- a/src/include/ABHelper.php	(revision fd32cf8d27bf4d8802bb6cddc7b310b67dc8dcc7)
+++ b/src/include/ABHelper.php	(date 1765952424630)
@@ -630,7 +630,7 @@
             case 'stopAll':
 
                 self::backupLog("Method: Stop all container before continuing.");
-                foreach ($containerListOverride ? array_reverse($containerListOverride) : $sortedStopContainers as $_container) {
+                foreach ($containerListOverride ? array_reverse($containerListOverride) : $sortedStopContainers as $key => $_container) {
                     $resolvedContainer = self::resolveContainer($_container, true);
                     foreach (($resolvedContainer !== false ? $resolvedContainer : [$_container]) as $container) {
                         self::setCurrentContainerName($container);
@@ -638,6 +638,7 @@
                         if ($preContainerRet === 2) {
                             self::backupLog("preContainer script decided to skip backup.");
                             self::setCurrentContainerName($container, true);
+                            unset($containerListOverride[$key]);
                             continue;
                         }
                         self::stopContainer($container);

You could replace the whole fil with this as an alternative: https://raw.githubusercontent.com/Commifreak/unraid-appdata.backup/745591fdef83f3204cee686db385d0d23aaeb333/src/include/ABHelper.php

[Zeager0]

I modified /usr/local/emhttp/plugins/appdata.backup/include/ABHelper.php. Hopefully thats the right one? Re-ran manual backup but it still did not skip the backup. Here are new logs.

backup.log

backup.debug.log

[Commifreak]

Ah, I see. The fix isnt fixing this correctly. I try to look into this.

[Commifreak]

Could you replace resolveContainer with this and try again? Keep the previous patch in place please.

    public static function resolveContainer($container, $reverse = false) {
        global $dockerContainers, $abSettings;
        if ($container['isGroup']) {
            $groupMembers = $abSettings->getContainerGroups($container['Name']);
            self::backupLog("Reached a group: " . $container['Name'], self::LOGLEVEL_DEBUG);
            $sortedGroupContainers = self::sortContainers($dockerContainers, $abSettings->containerGroupOrder[$container['Name']], $reverse, true, $groupMembers);
            self::backupLog("Containers in this group: " . implode(', ', array_column($sortedGroupContainers, 'Name')), self::LOGLEVEL_DEBUG);
            if (!empty($sortedGroupContainers)) {
                self::setCurrentContainerName($container);
            }
            return $sortedGroupContainers;
        }
        return false;
    }

[Zeager0]

It still fails to skip the backup of containers when in a group, but it does skip stopping the containers. I have included logs for runs with the new changes both when the containers are in a group(fail to skip) and nogroup(successful skip).

Group:
group-backup.log
group-ab.debug.log

No Group:
nogroup-backup.log
nogroup-ab.debug.log

and here is the ABHelper.php I am using with your changes:
ABhelper.php