triaging of spec test failures

Author: ColinEberhardt

assembly/__spec_tests__/generated.spec.ts

@@ -337,7 +337,7 @@ it("line: 71 - matches ((((((((((((((((((((((((((((((x))))))))))))))))))))))))))
   expect(match.matches[1]).toBe("x");
   expect(match.matches[2]).toBe("x");
 });
-xit("line: 72 - matches a?(ab|ba)* against 'ababababababababababababababababababababababababababababababababababababababababa'", () => {
+it("line: 72 - matches a?(ab|ba)* against 'ababababababababababababababababababababababababababababababababababababababababa'", () => {
   const match = exec(
     "a?(ab|ba)*",
     "ababababababababababababababababababababababababababababababababababababababababa",

spec/test-generator.js

@@ -7,28 +7,21 @@ const escape = (str) => str.replace("\\", "\\\\");
 
 const knownIssues = {
   "issue with parsing the test itself": [28, 58, 59, 78, 212, 213],
-  "issue with generating the test": [61, 62, 64],
-  "issue that require triage": [
-    20,
+  "issue with generating the test": [61, 62, 64, 76, 209, 210],
+  "unsupported POSIX regex syntax": [54, 55, 56],
+  "issue that require triage": [199, 202, 204, 205, 206, 207],
+  // I can't find a good reference that describes this behaviour!
+  "BUG: doesn't support anchors within capture groups": [20],
+  // https://github.com/ColinEberhardt/assemblyscript-regex/issues/2
+  "BUG: Should not return captured values for non-matching alternations": [
     35,
-    72,
-    76,
     133,
     150,
     187,
     188,
     190,
     191,
-    199,
-    202,
-    204,
-    205,
-    206,
-    207,
-    209,
-    210,
   ],
-  "unsupported POSIX regex syntax": [54, 55, 56],
 };
 
 const hasKnownIssue = (index) => {

ts/index.ts

@@ -5,7 +5,7 @@ globalAny.log = console.log;
 
 import { RegExp } from "../assembly/regexp";
 
-const regexObj = new RegExp("a+");
-const match = regexObj.exec("aa");
+const regexObj = new RegExp("^(([^!]+!)?([^!]+)|.+!([^!]+!)([^!]+))$");
+const match = regexObj.exec("foo!bar!bas");
 
 console.log(match);