From 0e199052a3aef666924d17c4dbabbb4db5157744 Mon Sep 17 00:00:00 2001 From: "Calvin A. Allen" Date: Fri, 2 Jan 2026 18:20:51 -0500 Subject: [PATCH] fix(build): use SetVsixVersion parameter and standardize output paths - Change -p:Version to -p:SetVsixVersion for correct VSIX versioning - Add OutputPath=bin/$(Configuration)/ to .csproj - Update artifact paths from bin/Release/net48/ to bin/Release/ - Rename build workflow from release_build_and_deploy.yml to build.yml - Update publish workflow to reference renamed build.yml --- .../workflows/{release_build_and_deploy.yml => build.yml} | 8 ++++---- .github/workflows/publish.yml | 2 +- .../CodingWithCalvin.OpenInNotepadPlusPlus.csproj | 1 + 3 files changed, 6 insertions(+), 5 deletions(-) rename .github/workflows/{release_build_and_deploy.yml => build.yml} (84%) diff --git a/.github/workflows/release_build_and_deploy.yml b/.github/workflows/build.yml similarity index 84% rename from .github/workflows/release_build_and_deploy.yml rename to .github/workflows/build.yml index c8e8577..47d908c 100644 --- a/.github/workflows/release_build_and_deploy.yml +++ b/.github/workflows/build.yml @@ -35,17 +35,17 @@ jobs: shell: pwsh - name: 3. Building Project - run: dotnet build src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj -c Release -p:Version=${{ steps.version.outputs.version }} + run: dotnet build src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj -c Release -p:SetVsixVersion=${{ steps.version.outputs.version }} - name: 4. Create Information File uses: jsdaniell/create-json@v1.2.3 with: - name: 'src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/net48/CodingWithCalvin.OpenInNotepadPlusPlus.info' + name: 'src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/CodingWithCalvin.OpenInNotepadPlusPlus.info' json: '{"sha":"${{ github.sha }}", "version":"${{ steps.version.outputs.version }}"}' - name: 5. Publishing Build Artifact uses: actions/upload-artifact@v4 with: path: | - src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/net48/CodingWithCalvin.OpenInNotepadPlusPlus.info - src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/net48/CodingWithCalvin.OpenInNotepadPlusPlus.vsix + src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/CodingWithCalvin.OpenInNotepadPlusPlus.info + src/CodingWithCalvin.OpenInNotepadPlusPlus/bin/Release/CodingWithCalvin.OpenInNotepadPlusPlus.vsix diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 7bb648f..38edf29 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -26,7 +26,7 @@ jobs: id: download-artifact uses: dawidd6/action-download-artifact@v6 with: - workflow: release_build_and_deploy.yml + workflow: build.yml workflow_conclusion: success - name: 2. Parse Artifact Manifest diff --git a/src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj b/src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj index 577b036..2e7ad26 100644 --- a/src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj +++ b/src/CodingWithCalvin.OpenInNotepadPlusPlus/CodingWithCalvin.OpenInNotepadPlusPlus.csproj @@ -5,6 +5,7 @@ CodingWithCalvin.OpenInNotepadPlusPlus CodingWithCalvin.OpenInNotepadPlusPlus latest + bin/$(Configuration)/