fix: move revenueholdings-license to optional [license] extra with graceful import fallback

- Remove revenueholdings-license>=0.1.0 from required dependencies
- Add license optional-dependencies group with revenueholdings-license
- Make require_license() import conditional: try/except ImportError
- On ImportError, define no-op require_license() and print warning
- Fixes CI breakage caused by revenueholdings-license not on PyPI (COM-79, COM-82, COM-83)

Author: Coding-Dev-Tools

pyproject.toml

@@ -36,6 +36,7 @@ dev = [
     "pytest>=7.0.0",
     "pytest-cov>=4.0.0",
 ]
+license = ["revenueholdings-license>=0.1.0"]
 
 [project.scripts]
 deadcode = "deadcode.cli:cli"

src/deadcode/cli.py

@@ -2,21 +2,25 @@
 
 from __future__ import annotations
 
-import click
 import json
 import sys
 from pathlib import Path
+from typing import Any
+
+import click
 from rich.console import Console
 from rich.table import Table
-
 try:
     from revenueholdings_license import require_license
 except ImportError:
-    require_license = None
+    import warnings
+    warnings.warn("revenueholdings-license not installed; license checks skipped", stacklevel=2)
+    def require_license(product: str) -> None:  # type: ignore[misc]
+        pass
 
 from . import __version__
 from .config import DeadCodeConfig
-from .scanner import DeadCodeScanner, Finding
+from .scanner import DeadCodeScanner, ScanResult, Finding
 
 console = Console()
 err_console = Console(stderr=True)
@@ -73,8 +77,7 @@ def _get_fail_threshold(ctx: click.Context) -> int:
 @click.pass_context
 def scan(ctx: click.Context, json_output: bool, category: str | None, fail_threshold: int | None) -> None:
     """Scan project for dead code."""
-    if require_license:
-        require_license("deadcode")
+    require_license("deadcode")
     project = ctx.obj["project"]
     ignore = _merge_config_ignore(ctx)
 
@@ -244,8 +247,7 @@ def remove(ctx: click.Context, dry_run: bool, category: str | None) -> None:
 @click.pass_context
 def stats(ctx: click.Context) -> None:
     """Show quick stats about the project's dead code."""
-    if require_license:
-        require_license("deadcode")
+    require_license("deadcode")
     project = ctx.obj["project"]
     ignore = _merge_config_ignore(ctx)
     scanner = DeadCodeScanner(project, ignore_patterns=ignore)