Skip to content

Commit 0aee4e1

Browse files
fix: remove dead --stream CLI flag (streaming is always used) (#20)
2 parents a436c2b + ad14058 commit 0aee4e1

3 files changed

Lines changed: 0 additions & 14 deletions

File tree

src/datamorph/cli.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,15 +67,13 @@ def cli() -> None:
6767
@click.option("--output-format", "-of", default=None, help="Output format (auto-detected from extension if omitted)")
6868
@click.option("--pretty", "-p", is_flag=True, help="Pretty-print JSON output")
6969
@click.option("--csv-delimiter", default=",", help="CSV delimiter (default: comma)")
70-
@click.option("--stream", is_flag=True, help="Use streaming mode (row-by-row, lower memory)")
7170
def convert_cmd(
7271
input: str,
7372
output: str,
7473
input_format: str | None,
7574
output_format: str | None,
7675
pretty: bool,
7776
csv_delimiter: str,
78-
stream: bool,
7977
) -> None:
8078
"""Convert INPUT file to OUTPUT format."""
8179
writer_kwargs: dict[str, Any] = {}
@@ -89,7 +87,6 @@ def convert_cmd(
8987
output,
9088
input_format=input_format,
9189
output_format=output_format,
92-
stream=stream,
9390
**writer_kwargs,
9491
)
9592

src/datamorph/converters.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,6 @@ def convert(
398398
output_path: str | Path,
399399
input_format: str | None = None,
400400
output_format: str | None = None,
401-
stream: bool = False,
402401
**writer_kwargs: Any,
403402
) -> ConversionResult:
404403
"""Convert a file from one format to another.
@@ -408,7 +407,6 @@ def convert(
408407
output_path: Destination file path.
409408
input_format: Source format (auto-detected from extension if None).
410409
output_format: Target format (auto-detected from extension if None).
411-
stream: If True, use streaming (row-by-row) conversion.
412410
**writer_kwargs: Additional kwargs passed to the format writer.
413411
414412
Returns:

tests/test_converters.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -388,15 +388,6 @@ def test_batch_no_input(self, runner, tmp_path):
388388
])
389389
assert result.exit_code == 0
390390

391-
def test_convert_with_stream_flag(self, runner, sample_csv, tmp_path):
392-
output = tmp_path / "out.json"
393-
result = runner.invoke(cli, [
394-
"convert", str(sample_csv), str(output),
395-
"--stream",
396-
])
397-
assert result.exit_code == 0
398-
assert "Converted" in result.output
399-
400391
def test_formats_show_streaming(self, runner):
401392
result = runner.invoke(cli, ["formats"])
402393
assert result.exit_code == 0

0 commit comments

Comments
 (0)