Update MongoDB Index

Author: maab16

src/Database/Drivers/MongoDB/Index.php

@@ -37,6 +37,10 @@ public static function getType(IndexInfo $index)
             $type = static::getSpecialType($index);
         }
 
+        if (empty($type)) {
+            $type = static::getDefaultType($index);
+        }
+
         return $type;
     }
 
@@ -46,52 +50,32 @@ protected static function getCommonType(IndexInfo $index)
 
         if ($index->isText()) {
             $type = "TEXT";
-        }
-
-        if ($index->is2dSphere()) {
+        } else if ($index->is2dSphere()) {
             $type = "2DSPARSE";
-        }
-
-        if ($index->isTtl()) {
+        } else if ($index->isTtl()) {
             $type = "TTL";
-        }
-
-        if ($index->isGeoHaystack()) {
+        } else if ($index->isGeoHaystack()) {
             $type = "GEOHAYSTACK";
         }
 
-        if ($type === "") {
-            $type = static::getDefaultType($index);
-        }
-
         return $type;
     }
 
     protected static function getSpecialType(IndexInfo $index)
     {
         $type = "";
 
-        if ($index->isUnique() && !$index->isSparse() && !static::checkDescending($index)) {
+        if (static::checkUnique($index)) {
             $type = "UNIQUE";
-        }
-
-        if ($index->isUnique() && !$index->isSparse() && static::checkDescending($index)) {
+        } else if (static::checkUniqueDesc($index)) {
             $type = "UNIQUE_DESC";
-        }
-
-        if ($index->isSparse() && !static::checkDescending($index)) {
+        } else if (static::checkSparse($index)) {
             $type = "SPARSE";
-        }
-
-        if ($index->isSparse() && $index->isUnique() && !static::checkDescending($index)) {
+        } else if (static::checkSparseUnique($index)) {
             $type = "SPARSE_UNIQUE";
-        }
-
-        if ($index->isSparse() && $index->isUnique() && static::checkDescending($index)) {
+        } else if (static::checkSparseUniqueDesc($index)) {
             $type = "SPARSE_UNIQUE_DESC";
-        }
-
-        if ($index->isSparse() && static::checkDescending($index)) {
+        } else if (static::checkSparseDesc($index)) {
             $type = "SPARSE_DESC";
         }
 
@@ -106,19 +90,45 @@ protected static function getDefaultType(IndexInfo $index)
 
         if ($type == 'asc') {
             return "ASC";
-        }
-
-        if ($type == 'index') {
+        } else if ($type == 'index') {
             return "INDEX";
-        }
-
-        if ($type == 'desc') {
+        } else if ($type == 'desc') {
             return "DESC";
         }
 
         return "";
     }
 
+    protected static function checkUnique($index)
+    {
+        return $index->isUnique() && !$index->isSparse() && !static::checkDescending($index) ? true : false;
+    }
+
+    protected static function checkUniqueDesc($index)
+    {
+        return $index->isUnique() && !$index->isSparse() && static::checkDescending($index) ? true : false;
+    }
+
+    protected static function checkSparse($index)
+    {
+        return $index->isSparse() && !static::checkDescending($index) ? true : false;
+    }
+
+    protected static function checkSparseUnique($index)
+    {
+        return $index->isSparse() && $index->isUnique() && !static::checkDescending($index) ? true : false;
+    }
+
+    protected static function checkSparseUniqueDesc($index)
+    {
+        return $index->isSparse() && $index->isUnique() && static::checkDescending($index) ? true : false;
+    }
+
+    protected static function checkSparseDesc($index)
+    {
+        return $index->isSparse() && static::checkDescending($index) ? true : false;
+    }
+
     protected static function checkDescending($index)
     {
         $keys = $index->getKey();