Rework Audio, FlxSound Stuffs

Look at below for more information about this commit
- FunkinCrew#11

Author: Raltyro

flixel/FlxGame.hx

@@ -597,6 +597,11 @@ class FlxGame extends Sprite
 		FlxG.sound.clearCache();
 		#end
 
+		// sound datas too.
+		#if FLX_SOUND_SYSTEM
+		FlxG.sound.clearCache();
+		#end
+
 		// Finally assign and create the new state
 		_state = _nextState.createInstance();
 		_state._constructor = _nextState.getConstructor();

flixel/sound/FlxSound.hx

@@ -1,6 +1,7 @@
 package flixel.sound;
 
 import lime.media.AudioBuffer;
+import lime.media.AudioEffect;
 import lime.media.AudioSource;
 
 import openfl.events.Event;
@@ -37,7 +38,7 @@ class FlxSound extends FlxBasic
 	/**
 	 * The default value for the `timeScaledPitch` variable at creation if none is specified in the constructor.
 	 */
-	public static var defaultTimeScaledPitch:Bool = true;
+	public static var defaultTimeScaledPitch:Bool = false;
 	#end
 
 	/**
@@ -251,11 +252,6 @@ class FlxSound extends FlxBasic
 	 */
 	public var pan(get, set):Float;
 
-	/**
-	 * The current sound playback filter used for this sound.
-	 */
-	public var filter(default, set):FlxSoundFilter;
-
 	/**
 	 * The duration/length of the sound in milliseconds.
 	 * @since 4.2.0
@@ -436,18 +432,19 @@ class FlxSound extends FlxBasic
 
 		if (force)
 		{
+			clearEffects();
+
 			persist = false;
 			loopUntil = -1;
 			proximityEnabled = false;
 			proximityPan = true;
 			scrollFactor?.set(0, 0);
 			target = null;
 			radius = 1024;
-			filter = null;
 
-			_looped = false;
-			_loopTime = 0;
-			_endTime = null;
+			looped = false;
+			loopTime = 0;
+			endTime = null;
 
 			#if FLX_PITCH
 			_timeScaledPitch = defaultTimeScaledPitch;
@@ -567,8 +564,8 @@ class FlxSound extends FlxBasic
 		alive = false;
 		exists = false;
 
-		_loopTime = 0;
-		_endTime = null;
+		loopTime = 0;
+		endTime = null;
 
 		return this;
 	}
@@ -733,10 +730,6 @@ class FlxSound extends FlxBasic
 		this.autoDestroy = autoDestroy;
 		this.onComplete = onComplete;
 
-		if (looped != null) _looped = looped;
-		if (loopTime != null) _loopTime = loopTime;
-		if (endTime != null) _endTime = endTime;
-
 		if (this.data != data)
 		{
 			if (data != null && !data.isDestroyed)
@@ -747,8 +740,6 @@ class FlxSound extends FlxBasic
 				source.buffer = data.buffer;
 				source.load();
 
-				source.loopTime = _loopTime;
-				source.length = _endTime;
 				loaded = true;
 			}
 			else
@@ -757,6 +748,10 @@ class FlxSound extends FlxBasic
 			}
 		}
 
+		if (looped != null) this.looped = looped;
+		if (loopTime != null) this.loopTime = loopTime;
+		if (endTime != null) this.endTime = endTime;
+
 		return this;
 	}
 
@@ -838,7 +833,7 @@ class FlxSound extends FlxBasic
 		if (pitch != null) _pitch = pitch;
 		#end
 		if (pan != null) _pan = pan;
-		if (endTime != null) _endTime = endTime;
+		if (endTime != null) this.endTime = endTime;
 
 		if (!loaded || (playing && !forceRestart)) return this;
 
@@ -881,7 +876,7 @@ class FlxSound extends FlxBasic
 		if (pitch != null) _pitch = pitch;
 		#end
 		if (pan != null) _pan = pan;
-		if (endTime != null) _endTime = endTime;
+		if (endTime != null) this.endTime = endTime;
 
 		if (!loaded) return this;
 
@@ -959,7 +954,8 @@ class FlxSound extends FlxBasic
 	 * @param	ease		EaseFunction to use for the tween.
 	 * @return	This FlxSound instance (nice for chaining stuff together, if you're into that).
 	 */
-	public function fadeOut(duration = 1.0, to = 0.0, ?onComplete:FlxTween->Void, ?ease:EaseFunction):FlxSound {
+	public function fadeOut(duration = 1.0, to = 0.0, ?onComplete:FlxTween->Void, ?ease:EaseFunction):FlxSound
+	{
 		fadeTween?.cancel();
 		fadeTween = FlxTween.num(_volume, to, duration, {ease: ease ?? FlxEase.quadIn, onComplete: onComplete}, volumeTween);
 
@@ -977,7 +973,8 @@ class FlxSound extends FlxBasic
 	 * @param	ease		EaseFunction to use for the tween.
 	 * @return	This FlxSound instance (nice for chaining stuff together, if you're into that).
 	 */
-	public function fadeIn(duration = 1.0, from = 0.0, to = 1.0, ?onComplete:FlxTween->Void, ?ease:EaseFunction):FlxSound {
+	public function fadeIn(duration = 1.0, from = 0.0, to = 1.0, ?onComplete:FlxTween->Void, ?ease:EaseFunction):FlxSound
+	{
 		if (!playing) play();
 
 		fadeTween?.cancel();
@@ -988,6 +985,61 @@ class FlxSound extends FlxBasic
 
 	function volumeTween(f:Float) volume = f;
 
+	/**
+	 * Adds an audio playback effect for this sound.
+	 * 
+	 * @param	effect	A `lime.media.AudioEffect` instance.
+	 * @since FunkinCrew's Flixel & Lime
+	 */
+	public function addEffect(effect:AudioEffect):Void
+	{
+		source.addEffect(effect);
+	}
+
+	/**
+	 * Removes an audio playback effect from this sound.
+	 * 
+	 * @param	effect	A `lime.media.AudioEffect` instance.
+	 * @since FunkinCrew's Flixel & Lime
+	 */
+	public function removeEffect(effect:AudioEffect):Void
+	{
+		source.removeEffect(effect);
+	}
+
+	/**
+	 * Clears any existing audio playback effects added in this sound.
+	 * @since FunkinCrew's Flixel & Lime
+	 */
+	public function clearEffects():Void
+	{
+		source.clearEffects();
+	}
+
+	/**
+	 * Returns the audio playback effect stred at the specified index.
+	 * 
+	 * @param	index	An index to the `lime.media.AudioEffect`.
+	 * @return	The specified `lime.media.AudioEffect` from the index.
+	 * @since FunkinCrew's Flixel & Lime
+	 */
+	public function getEffectAt(index:Int):AudioEffect
+	{
+		return source.getEffectAt(index);
+	}
+
+	/**
+	 * Returns the index of a desired audio playback effect stored.
+	 * 
+	 * @param	effect	A `lime.media.AudioEffect` instance.
+	 * @return	The index stored for the desired audio playback effect in this sound.
+	 * @since FunkinCrew's Flixel & Lime
+	 */
+	public function getEffectIndex(effect:AudioEffect):Int
+	{
+		return source.getEffectIndex(effect);
+	}
+
 	/**
 	 * Returns the currently selected "real" volume of the sound (takes fades and proximity).
 	 * 
@@ -1188,27 +1240,6 @@ class FlxSound extends FlxBasic
 		return value;
 	}
 
-	function set_filter(value:FlxSoundFilter):FlxSoundFilter
-	{
-		if (filter != value)
-		{
-			if (filter != null) filter.decrementUseCount();
-
-			if (value != null && !value.filter.disposed)
-			{
-				filter = value;
-				value.incrementUseCount();
-				source.filter = value.filter;
-			}
-			else
-			{
-				filter = null;
-				source.filter = null;
-			}
-		}
-		return filter;
-	}
-
 	function get_length():Float
 	{
 		return loaded ? data.length - offset : 0;
@@ -1369,18 +1400,17 @@ class FlxSound extends FlxBasic
 	@:allow(flixel.sound.FlxSoundGroup)
 	function _updateVolume():Void
 	{
-		if (_muted) source.gain = 0;
+		if (_muted || FlxG.sound._muted) source.gain = 0;
 		else source.gain = calcTransformVolume();
 	}
 
 	function calcTransformVolume():Float
 	{
-		final volume = getActualVolume();
-
 		#if FLX_SOUND_SYSTEM
-		return FlxG.sound.applySoundCurve(volume);
+		if (FlxG.sound._muted) return 0;
+		return FlxG.sound.applySoundCurve(getActualVolume() * FlxG.sound._volume);
 		#else
-		return volume;
+		return getActualVolume();
 		#end
 	}
 
@@ -1417,7 +1447,7 @@ class FlxSound extends FlxBasic
 		_amplitudeUpdated = true;
 		_amplitude = 0;
 
-		var peaks = source.__backend.getPeaks(get_time() - _lastTime);
+		final peaks = source.peaks;
 		for (i in 0...peaks.length)
 		{
 			_amplitudes[i] = peaks[i];