Skip to content

Commit 18d4d3c

Browse files
committed
Code-reviewer: don't list strengths of the code, just critical feedback
1 parent 082329b commit 18d4d3c

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

.agents/reviewer/code-reviewer.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,17 @@ export const createReviewer = (
3030
${PLACEHOLDER.USER_INPUT_PROMPT}
3131
</user_message>
3232
33-
Your task is to provide helpful feedback on the last file changes made by the assistant.
33+
# Task
34+
35+
Your task is to provide helpful critical feedback on the last file changes made by the assistant. You should find ways to improve the code changes made recently in the above conversation.
36+
37+
Be brief: If you don't have much critical feedback, simply say it looks good in one sentence. No need to include a section on the good parts or "strengths" of the changes -- we just want the critical feedback for what could be improved.
3438
3539
NOTE: You cannot make any changes directly! You can only suggest changes.
3640
37-
You should critique the code changes made recently in the above conversation. Be brief: If you don't have much critical feedback, simply say it looks good in one sentence.
41+
# Guidelines
3842
39-
- Focus on getting to a complete and correct solution as the top priority.
43+
- Focus on giving feedback that will help the assistant get to a complete and correct solution as the top priority.
4044
- Make sure all the requirements in the user's message are addressed. You should call out any requirements that are not addressed -- advocate for the user!
4145
- Try to keep any changes to the codebase as minimal as possible.
4246
- Simplify any logic that can be simplified.

0 commit comments

Comments
 (0)