From f26598e560378f1d3d80068943b9b63f6052ad2d Mon Sep 17 00:00:00 2001
From: Daniel Wagner-Hall <dawagner@gmail.com>
Date: Tue, 17 Mar 2026 15:55:47 +0000
Subject: [PATCH] Skip empty links in breadcrumbs

If a `_index.md` file has `build.render = "never"` set, it ends up as an
ancestor but without a link. This means we render a link with the title
of the page, but with a blank link, which makes a link to the current
page. This is never useful.

e.g. on https://piscine.codeyourfuture.io/sprints/1/day-plan/ there's a
"Piscine" link that has an empty `href` (so points at the current page)
which shouldn't be there. This is because
`org-cyf-piscine/content/sprints/_index.md` sets
`build.render = "never"` because it's a single-module course, so the
extra level of nesting isn't so useful.
---
 .../layouts/partials/breadcrumbs.html         | 50 ++++++++++---------
 1 file changed, 27 insertions(+), 23 deletions(-)

diff --git a/common-theme/layouts/partials/breadcrumbs.html b/common-theme/layouts/partials/breadcrumbs.html
index 447b39df0..073237e43 100644
--- a/common-theme/layouts/partials/breadcrumbs.html
+++ b/common-theme/layouts/partials/breadcrumbs.html
@@ -1,30 +1,34 @@
 {{ with .Parent }}
   <nav class="c-breadcrumbs">
     <ol class="c-breadcrumbs__list">
+      {{/* Skip the first ancestor which is the root page for the whole site - we already have a link here in the site logo. */}}
       {{- range after 1 .Ancestors.Reverse }}
-        <li class="c-breadcrumbs__item">
-          <a
-            class="c-breadcrumbs__link"
-            href="{{ .RelPermalink }}"
-            {{- if eq (len .Ancestors) 1 -}}
-              data-pagefind-filter="module"
-            {{- end -}}
-            ><span class="c-breadcrumbs__text">{{ .Title }}</span>
-            <svg
-              xmlns="http://www.w3.org/2000/svg"
-              fill="none"
-              viewBox="0 0 24 24"
-              width="24px"
-              stroke-width="1.5"
-              stroke="currentColor"
-              class="c-breadcrumbs__icon">
-              <path
-                stroke-linecap="round"
-                stroke-linejoin="round"
-                d="M8.25 4.5l7.5 7.5-7.5 7.5" />
-            </svg>
-          </a>
-        </li>
+        {{/* Skip any ancestors that don't have a link, e.g. ones that set build.render = "never". */}}
+        {{ if .RelPermalink }}
+          <li class="c-breadcrumbs__item">
+            <a
+              class="c-breadcrumbs__link"
+              href="{{ .RelPermalink }}"
+              {{- if eq (len .Ancestors) 1 -}}
+                data-pagefind-filter="module"
+              {{- end -}}
+              ><span class="c-breadcrumbs__text">{{ .Title }}</span>
+              <svg
+                xmlns="http://www.w3.org/2000/svg"
+                fill="none"
+                viewBox="0 0 24 24"
+                width="24px"
+                stroke-width="1.5"
+                stroke="currentColor"
+                class="c-breadcrumbs__icon">
+                <path
+                  stroke-linecap="round"
+                  stroke-linejoin="round"
+                  d="M8.25 4.5l7.5 7.5-7.5 7.5" />
+              </svg>
+            </a>
+          </li>
+        {{- end }}
       {{- end }}
       {{ if ne .Params.Build.render "never" }}
         <li class="c-breadcrumbs__item">