Skip to content

Rework how we explain PRs to students #1763

@Poonam-raj

Description

@Poonam-raj

Which module(s) and week(s) does this change affect?
Module(s): Onboarding / S+T in ITP

What is the work that needs to be done?

A combination of:

  • looking at the existing code review guide and checking that is guides students correctly through how they should engage with a PR.
  • Check ITP curriculum to signpost to the above code review guide better - maybe students are missing this guidance completely.

Why is this work important to do?

For Jan ITP we saw a lot of people falling into traps when trying to make their PR pass the GitHub bots. A few changes have already been made to make the PR template even clearer about what we require but the documentation around this might also need amending to follow through on this and signpost clearer.

Metadata

Metadata

Assignees

Labels

ITPWork belongs to or is needed for ITP

Type

No type

Projects

Status

📋 Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions