Fix: resolve sprint-3 PR feedback (logic, tests, clarity)

Author: MacDonald91

Sprint-3/2-practice-tdd/count.test.js

@@ -1,31 +1,9 @@
-// implement a function countChar that counts the number of times a character occurs in a string
-const countChar = require("./count");
-// Given a string `str` and a single character `char` to search for,
-// When the countChar function is called with these inputs,
-// Then it should:
-
-// Scenario: Multiple Occurrences
-// Given the input string `str`,
-// And a character `char` that occurs one or more times in `str` (e.g., 'a' in 'aaaaa'),
-// When the function is called with these inputs,
-// Then it should correctly count occurrences of `char`.
-
-test("should count multiple occurrences of a character", () => {
-  const str = "aaaaa";
-  const char = "a";
-  const count = countChar(str, char);
-  expect(count).toEqual(5);
+test("should be case sensitive", () => {
+  expect(countChar("Hello", "h")).toEqual(0);
+  expect(countChar("Hello", "H")).toEqual(1);
 });
 
-// Scenario: No Occurrences
-// Given the input string `str`,
-// And a character `char` that does not exist within `str`.
-// When the function is called with these inputs,
-// Then it should return 0, indicating that no occurrences of `char` were found.
-
-test("should return 0 when the character does not exist in the string", () => {
-  const str = "hello";
-  const char = "z";
-  const count = countChar(str, char);
-  expect(count).toEqual(0);
+test("should work with non-alphabet characters", () => {
+  expect(countChar("!!??!!", "!")).toEqual(4);
+  expect(countChar("123123", "1")).toEqual(2);
 });

Sprint-3/2-practice-tdd/get-ordinal-number.js

@@ -7,17 +7,9 @@ function getOrdinalNumber(num) {
     return num + "th";
   }
 
-  if (lastDigit === 1) {
-    return num + "st";
-  }
-
-  if (lastDigit === 2) {
-    return num + "nd";
-  }
-
-  if (lastDigit === 3) {
-    return num + "rd";
-  }
+  if (lastDigit === 1) return num + "st";
+  if (lastDigit === 2) return num + "nd";
+  if (lastDigit === 3) return num + "rd";
 
   return num + "th";
 }

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

@@ -46,8 +46,11 @@ test("should append 'th' for numbers ending with 11, 12, or 13", () => {
 });
 
 // Case 5: All other numbers should end with "th"
-test("should append 'th' for all other numbers", () => {
+test("should append 'th' for numbers ending in 0, 4–9 (excluding 11, 12, 13)", () => {
+  expect(getOrdinalNumber(0)).toEqual("0th");
   expect(getOrdinalNumber(4)).toEqual("4th");
+  expect(getOrdinalNumber(5)).toEqual("5th");
+  expect(getOrdinalNumber(9)).toEqual("9th");
   expect(getOrdinalNumber(10)).toEqual("10th");
   expect(getOrdinalNumber(100)).toEqual("100th");
 });