Implement isProperFraction and add assert and Jest tests"

Author: SandzSoft

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -11,7 +11,12 @@
 // execute the code to ensure all tests pass.
 
 function isProperFraction(numerator, denominator) {
-  // TODO: Implement this function
+  let numeratorVal = Math.abs(numerator);
+  let denominatorVal = Math.abs(denominator);
+
+  if (denominator === 0) return false;
+  if (numeratorVal < denominatorVal) return true;
+  return false;
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -26,8 +31,18 @@ function assertEquals(actualOutput, targetOutput) {
   );
 }
 
+assertEquals(isProperFraction(0, 4), true);
+assertEquals(isProperFraction(4, 0), false);
+assertEquals(isProperFraction(7, 4), false);
+assertEquals(isProperFraction(4, 7), true);
+assertEquals(isProperFraction(-7, 4), false);
+assertEquals(isProperFraction(7, -4), false);
+assertEquals(isProperFraction(-4, 7), true);
+assertEquals(isProperFraction(4, -7), true);
+assertEquals(isProperFraction(4, 4), false);
+
 // TODO: Write tests to cover all cases.
 // What combinations of numerators and denominators should you test?
 
 // Example: 1/2 is a proper fraction
-assertEquals(isProperFraction(1, 2), true);
+//assertEquals(isProperFraction(1, 2), true);

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -4,7 +4,34 @@ const isProperFraction = require("../implement/2-is-proper-fraction");
 
 // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories.
 
-// Special case: numerator is zero
-test(`should return false when denominator is zero`, () => {
-  expect(isProperFraction(1, 0)).toEqual(false);
+describe("isProperFraction", () => {
+  test("returns true when numerator is zero", () => {
+    expect(isProperFraction(0, 4)).toEqual(true);
+  });
+
+  test("returns false when denominator is zero", () => {
+    expect(isProperFraction(4, 0)).toEqual(false);
+  });
+
+  test("returns true for proper positive fractions", () => {
+    expect(isProperFraction(4, 7)).toEqual(true);
+  });
+
+  test("returns false for improper fractions", () => {
+    expect(isProperFraction(7, 4)).toEqual(false);
+  });
+
+  test("handles proper negative fractions", () => {
+    expect(isProperFraction(-4, 7)).toEqual(true);
+    expect(isProperFraction(4, -7)).toEqual(true);
+  });
+
+  test("handles improper negative fractions", () => {
+    expect(isProperFraction(-7, 4)).toEqual(false);
+    expect(isProperFraction(7, -4)).toEqual(false);
+  });
+
+  test("returns false when numerator equals denominator", () => {
+    expect(isProperFraction(4, 4)).toEqual(false);
+  });
 });