Skip to content

Get Code Review and Iterate #734

@illicitonion

Description

@illicitonion

As you progress through the backlog you will create a Pull Request (PR) for each exercise you complete.

Make sure you ask for review by adding the "Needs Review" label to the PR.

A volunteer will review it - you don't need to ask, just adding the label is enough.

When the volunteer has reviewed it, they will either give you more suggestions (and add the "Reviewed" label), or tell you it's perfect (and add the "Complete" label).

The github-actions bot may give you some automated feedback. If you get any you should address it, then add the "Needs Review" label again. Reviewers won't give feedback until the basic automated checks are complete.

Until the volunteer says it is complete, you should keep making improvements - whenever you're ready for more review, add the "Needs Review" label back.

If you've been waiting for review (whether initially, or after responding to comments) for more than a week, please ask for help on Slack in #cyf-code-review-team. Do not ask for review in #cyf-code-review-team until you've been waiting a week.

You will follow this same process for every PR you make at CodeYourFuture.

You can always remind yourself of what to do by visiting this guide

Metadata

Metadata

Assignees

No one assigned

    Labels

    Module-OnboardingThe name of the module.RecurringThis needs to be done in every sprintSubmit:NoneThere is no submission step for this work.🏕 Priority MandatoryThis work is expected🐂 Size Medium1-4 hours📅 Sprint 1Assigned during Sprint 1 of this module📅 Sprint 2Assigned during Sprint 2 of this module📅 Sprint 3Assigned during Sprint 3 of this module

    Type

    No type

    Projects

    Status

    📋 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions