From 8cfc50bc963e03bc481ea66ff41d9e0cc9718158 Mon Sep 17 00:00:00 2001 From: khalidbih Date: Wed, 3 Dec 2025 00:11:37 +0000 Subject: [PATCH 1/6] Fix median function all tests passing --- Sprint-1/fix/median.js | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index b22590bc6..b703aae6b 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -6,9 +6,30 @@ // or 'list' has mixed values (the function is expected to sort only numbers). function calculateMedian(list) { - const middleIndex = Math.floor(list.length / 2); - const median = list.splice(middleIndex, 1)[0]; - return median; + + if (!Array.isArray(list)) { + return null; + } + if (list.length === 0) { + return null; + } + + const numericList = list.filter(item => typeof item === "number" && !isNaN(item)); + + if (numericList.length === 0) { + return null; + } + + const sortedList = [...numericList].sort((a, b) => a - b); + const length = sortedList.length; + const middleIndex = Math.floor(length / 2); + + if (length % 2 === 0) { + return (sortedList[middleIndex - 1] + sortedList[middleIndex]) / 2; + } else { + return sortedList[middleIndex]; + } } module.exports = calculateMedian; + From 10675706a269433ce4e6cc512c1ead6662a11f8e Mon Sep 17 00:00:00 2001 From: khalidbih Date: Sat, 6 Dec 2025 21:26:16 +0000 Subject: [PATCH 2/6] Fix dedupe function --- Sprint-1/implement/dedupe.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index 781e8718a..c8ba732a7 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -1 +1,14 @@ -function dedupe() {} +function dedupe(arr) { + const seen = new Set(); + const result = [] + for (const item of arr){ + if (!seen.has(item)){ + seen.add(item); + result.push(item); + } + } + return result + } + + module.exports = dedupe; + From 8958df6cd826c287c9de3c1031584680a29f1a75 Mon Sep 17 00:00:00 2001 From: khalidbih Date: Sat, 6 Dec 2025 21:28:46 +0000 Subject: [PATCH 3/6] all test pass --- Sprint-1/implement/dedupe.test.js | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 23e0f8638..023c9cb20 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -11,17 +11,28 @@ E.g. dedupe([5, 1, 1, 2, 3, 2, 5, 8]) target output: [5, 1, 2, 3, 8] E.g. dedupe([1, 2, 1]) target output: [1, 2] */ + // Acceptance Criteria: // Given an empty array // When passed to the dedupe function // Then it should return an empty array -test.todo("given an empty array, it returns an empty array"); - +test("given an empty array, it returns an empty array",() => { + expect(dedupe([])).toEqual([]); +}); + // Given an array with no duplicates // When passed to the dedupe function // Then it should return a copy of the original array +test("returns the same array if there are no duplicates", () => { + expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]); + }); // Given an array with strings or numbers // When passed to the dedupe function // Then it should remove the duplicate values, preserving the first occurence of each element +it("removes duplicates and keeps the first occurrence", () => { + expect(dedupe([1, 2, 1, 3, 2])).toEqual([1, 2, 3]); + expect(dedupe(["a", "a", "b", "a", "c"])).toEqual(["a", "b", "c"]); + }); + From aed6d3abfbb5692eadb48019a3beafae29e96455 Mon Sep 17 00:00:00 2001 From: khalidbih Date: Tue, 9 Dec 2025 16:59:00 +0000 Subject: [PATCH 4/6] fixed the function --- Sprint-1/implement/max.js | 14 ++++++++++++++ Sprint-1/implement/max.test.js | 23 ++++++++++++++++++++++- Sprint-1/jest | 0 Sprint-1/week-1@1.0.0 | 0 4 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 Sprint-1/jest create mode 100644 Sprint-1/week-1@1.0.0 diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 6dd76378e..f0e161168 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,4 +1,18 @@ function findMax(elements) { + if (elements.length === 0) { + return -Infinity; + } + + let max = -Infinity; + + for (const item of elements) { + if (typeof item === "number" && item > max) { + max = item; + } + } + + return max; } module.exports = findMax; + diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 82f18fd88..6516e3102 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -16,28 +16,49 @@ const findMax = require("./max.js"); // When passed to the max function // Then it should return -Infinity // Delete this test.todo and replace it with a test. -test.todo("given an empty array, returns -Infinity"); +test("given an empty array, returns -Infinity", () => { + expect(findMax([])).toBe(-Infinity); +}); // Given an array with one number // When passed to the max function // Then it should return that number +test("given an array with one number, it returns that number", () => { + expect(findMax([7])).toBe(7); +}); // Given an array with both positive and negative numbers // When passed to the max function // Then it should return the largest number overall +test("given positive and negative numbers, it returns the largest number", () => { + expect(findMax([-5, 10, -2, 7])).toBe(10); +}); // Given an array with just negative numbers // When passed to the max function // Then it should return the closest one to zero +test("given an array with just negative numbers, it returns the closest to zero", () => { + expect(findMax([-10, -3, -20])).toBe(-3); +}); // Given an array with decimal numbers // When passed to the max function // Then it should return the largest decimal number +test("given an array with decimal numbers, it returns the largest decimal number", () => { + expect(findMax([1.2, 3.5, 2.8])).toBe(3.5); +}); // Given an array with non-number values // When passed to the max function // Then it should return the max and ignore non-numeric values +test("given an array with non-number values, it returns the max and ignores non-numeric values", () => { + expect(findMax(["hi", 10, "hello", 60, false, 20])).toBe(60); +}); // Given an array with only non-number values // When passed to the max function // Then it should return the least surprising value given how it behaves for all other inputs +test("given an array with only non-number values, it returns -Infinity", () => { + expect(findMax(["a", "hello", false, null, undefined])).toBe(-Infinity); +}); + diff --git a/Sprint-1/jest b/Sprint-1/jest new file mode 100644 index 000000000..e69de29bb diff --git a/Sprint-1/week-1@1.0.0 b/Sprint-1/week-1@1.0.0 new file mode 100644 index 000000000..e69de29bb From 8d1cad5699ad1de57be845b0506206096043fcf5 Mon Sep 17 00:00:00 2001 From: khalidbih Date: Tue, 9 Dec 2025 18:37:41 +0000 Subject: [PATCH 5/6] Fix function and tests --- Sprint-1/implement/sum.js | 9 ++++++++- Sprint-1/implement/sum.test.js | 19 ++++++++++++++++++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 9062aafe3..7733767e3 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -1,4 +1,11 @@ function sum(elements) { + let total = 0; + for (const el of elements) { + if (typeof el === "number") { + total += el; + } + } + return total; } - module.exports = sum; + diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index dd0a090ca..c61bdc7b3 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -13,24 +13,41 @@ const sum = require("./sum.js"); // Given an empty array // When passed to the sum function // Then it should return 0 -test.todo("given an empty array, returns 0") +test("given an empty array, returns 0", () => { + expect(sum([])).toBe(0); +}); // Given an array with just one number // When passed to the sum function // Then it should return that number +test("given an array with one number, returns that number", () => { + expect(sum([7])).toBe(7); +}); // Given an array containing negative numbers // When passed to the sum function // Then it should still return the correct total sum +test("given an array containing negative numbers, returns the correct sum", () => { + expect(sum([10, -5, 3, -2])).toBe(6); +}); // Given an array with decimal/float numbers // When passed to the sum function // Then it should return the correct total sum +test("given an array with decimal numbers, returns the correct sum", () => { + expect(sum([1.2, 3.5, 2.3])).toBe(7.0); +}); // Given an array containing non-number values // When passed to the sum function // Then it should ignore the non-numerical values and return the sum of the numerical elements +test("given an array with non-number values, returns the sum of numerical elements only", () => { + expect(sum([10, "hi", 5, null, 3, "hello"])).toBe(18); +}); // Given an array with only non-number values // When passed to the sum function // Then it should return the least surprising value given how it behaves for all other inputs +test("given an array with only non-number values, returns 0", () => { + expect(sum(["a", "hi", null, undefined, false])).toBe(0); +}); From 64d8a4ab9bb6e75d676e116c18703e7135cf21cf Mon Sep 17 00:00:00 2001 From: khalidbih Date: Tue, 9 Dec 2025 20:41:09 +0000 Subject: [PATCH 6/6] function fix --- Sprint-1/refactor/includes.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Sprint-1/refactor/includes.js b/Sprint-1/refactor/includes.js index 29dad81f0..d09cd496b 100644 --- a/Sprint-1/refactor/includes.js +++ b/Sprint-1/refactor/includes.js @@ -1,8 +1,6 @@ // Refactor the implementation of includes to use a for...of loop - function includes(list, target) { - for (let index = 0; index < list.length; index++) { - const element = list[index]; + for (const element of list) { if (element === target) { return true; } @@ -11,3 +9,5 @@ function includes(list, target) { } module.exports = includes; + +