diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..0d05f114 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,11 +1,10 @@ - + Book Library @@ -31,7 +30,7 @@

Library

Library /> Library type="submit" value="Submit" class="btn btn-primary" - onclick="submit();" + id="submitBtn" />
@@ -80,7 +79,7 @@

Library

- + @@ -91,6 +90,6 @@

Library

- + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..bebd92f5 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,44 +1,51 @@ let myLibrary = []; +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const isReadInput = document.getElementById("check"); + +const submitBtn = document.getElementById("submitBtn"); +submitBtn.addEventListener("click", submit); + window.addEventListener("load", function (e) { populateStorage(); render(); }); +//just one thing need to check function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + if (myLibrary.length === 0) { + const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true); + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); myLibrary.push(book1); myLibrary.push(book2); - render(); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); - //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { + //if any of the information is missing show an alert + const titleValue = titleInput.value.trim(); + const authorValue = authorInput.value.trim(); + const pagesValue = Number(pagesInput.value); + if (!titleValue || !authorValue || !Number.isInteger(pagesValue) || pagesValue <= 0) { alert("Please fill all fields!"); - return false; + return; } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + const book = new Book( + titleValue, + authorValue, + pagesValue, + isReadInput.checked + ); + myLibrary.push(book); render(); } } @@ -51,52 +58,45 @@ function Book(title, author, pages, check) { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); - } + const tableBody = document.getElementById("tbody"); + tableBody.textContent = ""; //insert updated row and cells - let length = myLibrary.length; + const length = myLibrary.length; for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const row = tableBody.insertRow(); // why (1) not i+1 insert with four + const titleCell = row.insertCell(0); // the table.rows and row.cells are HTMLCollection,not a real array, but they behave like array(indexed,length) . they are DOM collections + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); // it is like insert for + titleCell.textContent = myLibrary[i].title; //filling the cells why innerHTML + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); + const changeReadBut = document.createElement("button"); + changeReadBut.className = "btn btn-success"; + wasReadCell.appendChild(changeReadBut); let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; + readStatus= myLibrary[i].check===true? "yes":"no"; + + changeReadBut.textContent = readStatus; - changeBut.addEventListener("click", function () { + changeReadBut.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + + const deleteBut = document.createElement("button"); + deleteCell.appendChild(deleteBut); + deleteBut.className = "btn btn-warning"; + deleteBut.textContent = "Delete"; + deleteBut.addEventListener("click", function () { + const deletedTitle = myLibrary[i].title; myLibrary.splice(i, 1); + alert(`You've deleted title: ${deletedTitle}`); render(); }); }