diff --git a/.vscode/launch.json b/.vscode/launch.json new file mode 100644 index 00000000..2ba986f6 --- /dev/null +++ b/.vscode/launch.json @@ -0,0 +1,15 @@ +{ + // Use IntelliSense to learn about possible attributes. + // Hover to view descriptions of existing attributes. + // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 + "version": "0.2.0", + "configurations": [ + { + "type": "chrome", + "request": "launch", + "name": "Launch Chrome against localhost", + "url": "http://localhost:8080", + "webRoot": "${workspaceFolder}" + } + ] +} \ No newline at end of file diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..b091233c 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,16 @@ - + - - + + + Book Library + + + + - - @@ -23,50 +19,24 @@

Library

Add books to your virtual library

- +
- - - + + + + + - + + - + +
@@ -80,17 +50,9 @@

Library

- - - - - - - - - + - + diff --git a/debugging/book-library/readme.md b/debugging/book-library/readme.md index 3abe8c13..e86a1c29 100644 --- a/debugging/book-library/readme.md +++ b/debugging/book-library/readme.md @@ -12,12 +12,20 @@ My website should be able to: ## Bugs to be fixed -1. Website loads but doesn't show any books -2. Error in console when you try to add a book -3. It uses the title name as the author name -4. Delete button is broken +1. Website loads but doesn't show any books + |Ans: fixed to show books +2. Error in console when you try to add a book + Ans: We can add now. +3. It uses the title name as the author name + Ans: has been fixed +4. Delete button is broken + ANs: has been functional 5. When I add a book that I say I've read - it saves the wrong answer + Ans: it is working normal I think there are other some other small bugs in my code...but I'm lazy so I can't fix them all. + -- Page number used to accept 0 or even negative numbers. Now it only accept >=1 I wish somebody would help me! + +I think I have tried something. diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..0c5bcda6 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,103 +1,115 @@ -let myLibrary = []; +// script.js (module) -window.addEventListener("load", function (e) { - populateStorage(); - render(); -}); +export {}; -function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true - ); - myLibrary.push(book1); - myLibrary.push(book2); - render(); +// Library array +const myLibrary = []; + +// Book constructor +class Book { + constructor(title, author, pages, read) { + this.title = title; + this.author = author; + this.pages = pages; + this.read = read; } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +// Default books +const defaultBooks = [ + new Book("Robinson Crusoe", "Daniel Defoe", 252, true), + new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true), +]; + +// DOM references +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readCheckbox = document.getElementById("check"); +const submitBtn = document.getElementById("submitBtn"); +const table = document.getElementById("display"); + +// On page load: add default books + +window.addEventListener("DOMContentLoaded", () => { + if (myLibrary.length === 0) { + myLibrary.push(...defaultBooks); + } + render(); +}); + +// Submit listener +submitBtn.addEventListener("click", submit); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function +// Submit function function submit() { - if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" - ) { + const titleVal = titleInput.value.trim(); + const authorVal = authorInput.value.trim(); + const pagesVal = pagesInput.value.trim(); + const readVal = readCheckbox.checked; + + if (!titleVal || !authorVal || !pagesVal) { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); + return; + } + + const pagesNum = Number(pagesVal); + if (!Number.isInteger(pagesNum) || pagesNum < 1) { + alert("Pages must be an integer greater than or equal to 1!"); + return; } -} -function Book(title, author, pages, check) { - this.title = title; - this.author = author; - this.pages = pages; - this.check = check; + myLibrary.push(new Book(titleVal, authorVal, pagesNum, readVal)); + + titleInput.value = ""; + authorInput.value = ""; + pagesInput.value = ""; + readCheckbox.checked = false; + + render(); } +// Render function function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { - myLibrary[i].check = !myLibrary[i].check; + const tbody = table.tBodies[0]; + + + tbody.innerHTML = ""; + + myLibrary.forEach((book, index) => { + const row = tbody.insertRow(); + + row.insertCell(0).textContent = book.title; + row.insertCell(1).textContent = book.author; + row.insertCell(2).textContent = book.pages; + + // Read button + const readCell = row.insertCell(3); + const readBtn = document.createElement("button"); + readBtn.className = "btn btn-success"; + readBtn.textContent = book.read ? "Yes" : "No"; + readBtn.addEventListener("click", () => { + book.read = !book.read; render(); }); + readCell.appendChild(readBtn); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); - myLibrary.splice(i, 1); - render(); + // Delete button + const deleteCell = row.insertCell(4); + const deleteBtn = document.createElement("button"); + deleteBtn.className = "btn btn-warning"; + deleteBtn.textContent = "Delete"; + deleteBtn.addEventListener("click", () => { + if (confirm(`Are you sure you want to delete "${book.title}"?`)) { + myLibrary.splice(index, 1); + render(); + alert("Book deleted successfully!"); + } }); - } + deleteCell.appendChild(deleteBtn); + }); } + + +// Modifications regarding input preprocessing table rendering and descriptive +// names have been made. \ No newline at end of file