feat: refactor backup command to use GetRequiredString for interactive prompts

- Replace PromptIfMissing calls with GetRequiredString for host, user, repo-dir, password-file, and paths flags
- Add help text for each prompt explaining the purpose of each field
- Check flag.Changed() status before prompting to respect explicitly set flags
- Remove unused CephClient method stub tests from platform_compatibility_test.go

Author: CodeMonkeyCybersecurity

cmd/create/backup.go

@@ -43,11 +43,65 @@ var CreateBackupCmd = &cobra.Command{
 then creates a backup of specified directories.`,
 	RunE: eos.Wrap(func(rc *eos_io.RuntimeContext, cmd *cobra.Command, args []string) error {
 
-		backupOpts.Host, _ = interaction.PromptIfMissing(rc.Ctx, cmd, "host", "Enter backup host", false)
-		backupOpts.User, _ = interaction.PromptIfMissing(rc.Ctx, cmd, "user", "Enter backup user", false)
-		backupOpts.RepoDir, _ = interaction.PromptIfMissing(rc.Ctx, cmd, "repo-dir", "Enter remote restic repo directory", false)
-		backupOpts.PasswordFile, _ = interaction.PromptIfMissing(rc.Ctx, cmd, "password-file", "Enter restic password file", false)
-		pathsFlag, _ = interaction.PromptIfMissing(rc.Ctx, cmd, "paths", "Enter paths to backup (comma separated)", false)
+		hostFlag, _ := cmd.Flags().GetString("host")
+		hostWasSet := cmd.Flags().Changed("host")
+		hostResult, err := interaction.GetRequiredString(rc, hostFlag, hostWasSet, &interaction.RequiredFlagConfig{
+			FlagName:      "host",
+			PromptMessage: "Enter backup host: ",
+			HelpText:      "Hostname or IP of the restic repository server",
+		})
+		if err != nil {
+			return err
+		}
+		backupOpts.Host = hostResult.Value
+
+		userFlag, _ := cmd.Flags().GetString("user")
+		userWasSet := cmd.Flags().Changed("user")
+		userResult, err := interaction.GetRequiredString(rc, userFlag, userWasSet, &interaction.RequiredFlagConfig{
+			FlagName:      "user",
+			PromptMessage: "Enter backup user: ",
+			HelpText:      "SSH user used to connect to the backup server",
+		})
+		if err != nil {
+			return err
+		}
+		backupOpts.User = userResult.Value
+
+		repoFlag, _ := cmd.Flags().GetString("repo-dir")
+		repoWasSet := cmd.Flags().Changed("repo-dir")
+		repoResult, err := interaction.GetRequiredString(rc, repoFlag, repoWasSet, &interaction.RequiredFlagConfig{
+			FlagName:      "repo-dir",
+			PromptMessage: "Enter remote restic repo directory: ",
+			HelpText:      "Directory on the backup host that stores restic repositories",
+		})
+		if err != nil {
+			return err
+		}
+		backupOpts.RepoDir = repoResult.Value
+
+		passwordFileFlag, _ := cmd.Flags().GetString("password-file")
+		passwordFileWasSet := cmd.Flags().Changed("password-file")
+		passwordFileResult, err := interaction.GetRequiredString(rc, passwordFileFlag, passwordFileWasSet, &interaction.RequiredFlagConfig{
+			FlagName:      "password-file",
+			PromptMessage: "Enter restic password file: ",
+			HelpText:      "Local file path that stores the restic repository password",
+		})
+		if err != nil {
+			return err
+		}
+		backupOpts.PasswordFile = passwordFileResult.Value
+
+		pathsFlagValue, _ := cmd.Flags().GetString("paths")
+		pathsWasSet := cmd.Flags().Changed("paths")
+		pathsResult, err := interaction.GetRequiredString(rc, pathsFlagValue, pathsWasSet, &interaction.RequiredFlagConfig{
+			FlagName:      "paths",
+			PromptMessage: "Enter paths to backup (comma separated): ",
+			HelpText:      "Specify one or more directories to include in the restic backup",
+		})
+		if err != nil {
+			return err
+		}
+		pathsFlag = pathsResult.Value
 		if pathsFlag != "" {
 			for _, p := range strings.Split(pathsFlag, ",") {
 				p = strings.TrimSpace(p)

pkg/cephfs/platform_compatibility_darwin_test.go

@@ -0,0 +1,50 @@
+//go:build darwin
+// +build darwin
+
+package cephfs
+
+import (
+	"testing"
+
+	"github.com/CodeMonkeyCybersecurity/eos/pkg/testutil"
+	"github.com/stretchr/testify/assert"
+)
+
+// TestCephClientStubMethods exercises stubbed CephClient methods that only
+// exist on macOS builds to ensure they return platform errors.
+func TestCephClientStubMethods(t *testing.T) {
+	rc := testutil.TestContext(t)
+
+	config := &ClientConfig{
+		ClusterName: "ceph",
+		User:        "admin",
+		MonHosts:    []string{"10.0.0.1"},
+	}
+
+	client, _ := NewCephClient(rc, config)
+	stubClient := &CephClient{}
+
+	err := stubClient.Connect()
+	assert.Error(t, err)
+	assert.Contains(t, err.Error(), "not available")
+
+	stats, err := stubClient.GetClusterStats()
+	assert.Error(t, err)
+	assert.Nil(t, stats)
+
+	exists, err := stubClient.VolumeExists(rc, "test")
+	assert.Error(t, err)
+	assert.False(t, exists)
+
+	volumes, err := stubClient.ListVolumes(rc)
+	assert.Error(t, err)
+	assert.Nil(t, volumes)
+
+	err = stubClient.CreateVolume(rc, &VolumeCreateOptions{Name: "test"})
+	assert.Error(t, err)
+
+	err = stubClient.DeleteVolume(rc, "test", false)
+	assert.Error(t, err)
+
+	assert.Nil(t, client, "NewCephClient should return nil client on macOS")
+}

pkg/cephfs/platform_compatibility_test.go

@@ -115,55 +115,6 @@ func TestPlatformStubBehavior(t *testing.T) {
 		}
 	})
 
-	// Test CephClient method stubs
-	t.Run("CephClient_methods_return_platform_errors", func(t *testing.T) {
-		if runtime.GOOS != "darwin" {
-			t.Skip("This test only runs on macOS to verify stubs")
-		}
-
-		config := &ClientConfig{
-			ClusterName: "ceph",
-			User:        "admin",
-			MonHosts:    []string{"10.0.0.1"},
-		}
-
-		client, _ := NewCephClient(rc, config)
-		// client will be nil on macOS, but we can test the methods on a zero-value struct
-		stubClient := &CephClient{}
-
-		// Test Connect stub
-		err := stubClient.Connect()
-		assert.Error(t, err)
-		assert.Contains(t, err.Error(), "not available")
-
-		// Test GetClusterStats stub
-		stats, err := stubClient.GetClusterStats()
-		assert.Error(t, err)
-		assert.Nil(t, stats)
-
-		// Test VolumeExists stub
-		exists, err := stubClient.VolumeExists(rc, "test")
-		assert.Error(t, err)
-		assert.False(t, exists)
-
-		// Test ListVolumes stub
-		volumes, err := stubClient.ListVolumes(rc)
-		assert.Error(t, err)
-		assert.Nil(t, volumes)
-
-		// Test CreateVolume stub (method, not function)
-		err = stubClient.CreateVolume(rc, &VolumeCreateOptions{
-			Name: "test",
-		})
-		assert.Error(t, err)
-
-		// Test DeleteVolume stub
-		err = stubClient.DeleteVolume(rc, "test", false)
-		assert.Error(t, err)
-
-		// Client should be nil on macOS
-		assert.Nil(t, client, "NewCephClient should return nil client on macOS")
-	})
 }
 
 // TestValidateConfig_CrossPlatform verifies validation works on all platforms