From f978996cf52d66e732de9db60830492a2e17bcb9 Mon Sep 17 00:00:00 2001 From: Kathryn Date: Tue, 27 Sep 2016 19:40:43 -0400 Subject: [PATCH 1/7] odd numbers --- src/odd_numbers.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 src/odd_numbers.php diff --git a/src/odd_numbers.php b/src/odd_numbers.php new file mode 100644 index 0000000..4feeed2 --- /dev/null +++ b/src/odd_numbers.php @@ -0,0 +1,13 @@ + From cc4a33905c656994a709a8d2593aad01b2793b14 Mon Sep 17 00:00:00 2001 From: Kathryn Date: Tue, 27 Sep 2016 19:47:47 -0400 Subject: [PATCH 2/7] odd challenge --- src/odd_numbers.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/odd_numbers.php b/src/odd_numbers.php index 4feeed2..748eb06 100644 --- a/src/odd_numbers.php +++ b/src/odd_numbers.php @@ -5,9 +5,11 @@ function odd_numbers($array){ $output=[]; foreach($array as $value){ - if (($value % 2)==1){ - $output[]=$value; + if ($value > 0){ + if (($value % 2)==1){ + $output[]=$value; } + } }return $output; } ?> From 3e0090bbb881b0dc044794459c11efe536d170cd Mon Sep 17 00:00:00 2001 From: Kathryn Date: Tue, 27 Sep 2016 19:55:12 -0400 Subject: [PATCH 3/7] odd integer --- src/odd_numbers.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/odd_numbers.php b/src/odd_numbers.php index 748eb06..4a86956 100644 --- a/src/odd_numbers.php +++ b/src/odd_numbers.php @@ -5,7 +5,7 @@ function odd_numbers($array){ $output=[]; foreach($array as $value){ - if ($value > 0){ + if ($value > 0 && is_int($value)){ if (($value % 2)==1){ $output[]=$value; } From fa8ad77015b19e8e337956d56f410eabcd84ff19 Mon Sep 17 00:00:00 2001 From: Kathryn Date: Tue, 27 Sep 2016 20:28:55 -0400 Subject: [PATCH 4/7] not zero --- src/odd_numbers.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/odd_numbers.php b/src/odd_numbers.php index 4a86956..409410d 100644 --- a/src/odd_numbers.php +++ b/src/odd_numbers.php @@ -5,7 +5,7 @@ function odd_numbers($array){ $output=[]; foreach($array as $value){ - if ($value > 0 && is_int($value)){ + if ($value !=0 && is_int($value)){ if (($value % 2)==1){ $output[]=$value; } From d64e94f8a0879c7298f7b406ed5038e83d8cd618 Mon Sep 17 00:00:00 2001 From: Kathryn Date: Tue, 27 Sep 2016 20:35:21 -0400 Subject: [PATCH 5/7] incl neg numbers --- src/odd_numbers.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/odd_numbers.php b/src/odd_numbers.php index 409410d..4c18232 100644 --- a/src/odd_numbers.php +++ b/src/odd_numbers.php @@ -6,7 +6,7 @@ function odd_numbers($array){ foreach($array as $value){ if ($value !=0 && is_int($value)){ - if (($value % 2)==1){ + if (($value % 2)**2 ==1 ){ $output[]=$value; } } From 8c99f4779d4836fea6dfde49379707b85bd82915 Mon Sep 17 00:00:00 2001 From: Kathryn Date: Tue, 27 Sep 2016 20:41:08 -0400 Subject: [PATCH 6/7] squared removed --- src/odd_numbers.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/odd_numbers.php b/src/odd_numbers.php index 4c18232..4220196 100644 --- a/src/odd_numbers.php +++ b/src/odd_numbers.php @@ -6,7 +6,7 @@ function odd_numbers($array){ foreach($array as $value){ if ($value !=0 && is_int($value)){ - if (($value % 2)**2 ==1 ){ + if (($value % 2) ==1 || -1){ $output[]=$value; } } From a01218aeb32d7633cb74800aaf205dbb6ae9b0db Mon Sep 17 00:00:00 2001 From: Kathryn Date: Tue, 27 Sep 2016 20:45:39 -0400 Subject: [PATCH 7/7] or statement changed --- src/odd_numbers.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/odd_numbers.php b/src/odd_numbers.php index 4220196..2e37f2f 100644 --- a/src/odd_numbers.php +++ b/src/odd_numbers.php @@ -6,7 +6,7 @@ function odd_numbers($array){ foreach($array as $value){ if ($value !=0 && is_int($value)){ - if (($value % 2) ==1 || -1){ + if (($value % 2) ==1 || ($value % 2) == -1){ $output[]=$value; } }