Skip to content

Commit 2c00fd1

Browse files
Apply suggestions from code review
Co-authored-by: Khan Winter <35942988+thecoolwinter@users.noreply.github.com>
1 parent 6076b03 commit 2c00fd1

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CodeEdit/Features/Editor/JumpBar/Views/EditorJumpBarComponent.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ struct EditorJumpBarComponent: View {
7575
.mask(
7676
LinearGradient(
7777
gradient: Gradient(
78-
stops: truncatedCrumbWidth == nil ?
78+
stops: truncatedCrumbWidth == nil || isHovering ?
7979
[
8080
.init(color: .black, location: 0),
8181
.init(color: .black, location: 1)

CodeEdit/Features/Editor/JumpBar/Views/EditorJumpBarView.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ struct EditorJumpBarView: View {
6767
? isActiveEditor ? .primary : .secondary
6868
: Color(nsColor: .tertiaryLabelColor)
6969
)
70+
.frame(maxHeight: .infinity)
7071
} else {
7172
ForEach(fileItems, id: \.self) { fileItem in
7273
EditorJumpBarComponent(
@@ -146,7 +147,7 @@ struct EditorJumpBarView: View {
146147
crumbWidth = nil
147148
}
148149

149-
if betweenWidth > snapThreshold {
150+
if betweenWidth > snapThreshold || crumbWidth == nil {
150151
firstCrumbWidth = nil
151152
} else {
152153
let otherCrumbs = CGFloat(max(fileItems.count - 1, 1))

0 commit comments

Comments
 (0)