Skip to content

Commit d4030a6

Browse files
Seulgi Kimsgkim126
authored andcommitted
Use H256::zero() instead of H256::from(0)
1 parent 15af515 commit d4030a6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

json/src/hash.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ macro_rules! impl_hash {
5959
where
6060
E: Error, {
6161
let value = match value.len() {
62-
0 => $inner::from(0),
63-
2 if value == "0x" => $inner::from(0),
62+
0 => $inner::zero(),
63+
2 if value == "0x" => $inner::zero(),
6464
_ if value.starts_with("0x") => $inner::from_str(&value[2..])
6565
.map_err(|e| Error::custom(format!("Invalid hex value {}: {}", value, e).as_str()))?,
6666
_ => $inner::from_str(value)
@@ -105,13 +105,13 @@ mod test {
105105
let s = r#"["", "5a39ed1020c04d4d84539975b893a4e7c53eab6c2965db8bc3468093a31bc5ae"]"#;
106106
let deserialized: Vec<H256> = serde_json::from_str(s).unwrap();
107107
assert_eq!(deserialized, vec![
108-
H256(primitives::H256::from(0)),
108+
H256(primitives::H256::zero()),
109109
H256(primitives::H256::from("5a39ed1020c04d4d84539975b893a4e7c53eab6c2965db8bc3468093a31bc5ae")),
110110
]);
111111
}
112112

113113
#[test]
114114
fn hash_into() {
115-
assert_eq!(primitives::H256::from(0), H256(primitives::H256::from(0)).into());
115+
assert_eq!(primitives::H256::zero(), H256(primitives::H256::zero()).into());
116116
}
117117
}

0 commit comments

Comments
 (0)