Allow struct/array to overflow

Author: Seulgi Kim

core/src/client/importer.rs

@@ -237,15 +237,11 @@ impl Importer {
             cdebug!(CLIENT, "Epoch transition at block {}", header.hash());
 
             let mut batch = DBTransaction::new();
-            chain.insert_epoch_transition(
-                &mut batch,
-                header.number(),
-                EpochTransition {
-                    block_hash: header.hash(),
-                    block_number: header.number(),
-                    proof,
-                },
-            );
+            chain.insert_epoch_transition(&mut batch, header.number(), EpochTransition {
+                block_hash: header.hash(),
+                block_number: header.number(),
+                proof,
+            });
 
             // always write the batch directly since epoch transition proofs are
             // fetched from a DB iterator and DB iterators are only available on

core/src/consensus/tendermint/worker.rs

@@ -918,16 +918,13 @@ impl Worker {
     }
 
     fn backup(&self) {
-        backup(
-            self.client().get_kvdb().as_ref(),
-            BackupView {
-                height: &self.height,
-                view: &self.view,
-                step: &self.step.to_step(),
-                votes: &self.votes.get_all(),
-                last_confirmed_view: &self.last_confirmed_view,
-            },
-        );
+        backup(self.client().get_kvdb().as_ref(), BackupView {
+            height: &self.height,
+            view: &self.view,
+            step: &self.step.to_step(),
+            votes: &self.votes.get_all(),
+            last_confirmed_view: &self.last_confirmed_view,
+        });
     }
 
     fn restore(&mut self) {

core/src/miner/mem_pool.rs

@@ -1447,14 +1447,10 @@ pub mod test {
         let mut inputs: Vec<MemPoolInput> = Vec::new();
 
         inputs.push(create_mempool_input_with_pay(1u64, keypair, no_timelock));
-        inputs.push(create_mempool_input_with_pay(
-            3u64,
-            keypair,
-            TxTimelock {
-                block: Some(10),
-                timestamp: None,
-            },
-        ));
+        inputs.push(create_mempool_input_with_pay(3u64, keypair, TxTimelock {
+            block: Some(10),
+            timestamp: None,
+        }));
         inputs.push(create_mempool_input_with_pay(5u64, keypair, no_timelock));
         mem_pool.add(inputs, inserted_block_number, inserted_timestamp, &fetch_account);
 

core/src/miner/work_notify.rs

@@ -69,21 +69,15 @@ impl NotifyWork for WorkPoster {
         let body = format!(r#"{{ "result": ["0x{:x}","0x{:x}"] }}"#, pow_hash, target);
         let mut client = self.client.lock();
         for u in &self.urls {
-            if let Err(e) = client.request(
-                u.clone(),
-                PostHandler {
-                    body: body.clone(),
-                },
-            ) {
+            if let Err(e) = client.request(u.clone(), PostHandler {
+                body: body.clone(),
+            }) {
                 cwarn!(MINER, "Error sending HTTP notification to {} : {}, retrying", u, e);
                 // TODO: remove this once https://github.com/hyperium/hyper/issues/848 is fixed
                 *client = WorkPoster::create_client();
-                if let Err(e) = client.request(
-                    u.clone(),
-                    PostHandler {
-                        body: body.clone(),
-                    },
-                ) {
+                if let Err(e) = client.request(u.clone(), PostHandler {
+                    body: body.clone(),
+                }) {
                     cwarn!(MINER, "Error sending HTTP notification to {} : {}", u, e);
                 }
             }

json/src/hash.rs

@@ -109,13 +109,10 @@ mod test {
     fn hash_deserialization() {
         let s = r#"["", "5a39ed1020c04d4d84539975b893a4e7c53eab6c2965db8bc3468093a31bc5ae"]"#;
         let deserialized: Vec<H256> = serde_json::from_str(s).unwrap();
-        assert_eq!(
-            deserialized,
-            vec![
-                H256(primitives::H256::from(0)),
-                H256(primitives::H256::from("5a39ed1020c04d4d84539975b893a4e7c53eab6c2965db8bc3468093a31bc5ae")),
-            ]
-        );
+        assert_eq!(deserialized, vec![
+            H256(primitives::H256::from(0)),
+            H256(primitives::H256::from("5a39ed1020c04d4d84539975b893a4e7c53eab6c2965db8bc3468093a31bc5ae")),
+        ]);
     }
 
     #[test]

json/src/uint.rs

@@ -151,17 +151,14 @@ mod test {
     fn uint_deserialization() {
         let s = r#"["0xa", "10", "", "0x", 0, "0xffffffffffffffff"]"#;
         let deserialized: Vec<Uint> = serde_json::from_str(s).unwrap();
-        assert_eq!(
-            deserialized,
-            vec![
-                Uint(U256::from(10)),
-                Uint(U256::from(10)),
-                Uint(U256::from(0)),
-                Uint(U256::from(0)),
-                Uint(U256::from(0)),
-                ::std::u64::MAX.into(),
-            ]
-        );
+        assert_eq!(deserialized, vec![
+            Uint(U256::from(10)),
+            Uint(U256::from(10)),
+            Uint(U256::from(0)),
+            Uint(U256::from(0)),
+            Uint(U256::from(0)),
+            ::std::u64::MAX.into(),
+        ]);
     }
 
     #[test]

keystore/tests/api.rs

@@ -109,10 +109,10 @@ fn ciphertext_path() -> &'static str {
 fn secret_store_load_pat_files() {
     let dir = RootDiskDirectory::at(pat_path());
     let store = KeyStore::open(Box::new(dir)).unwrap();
-    assert_eq!(
-        store.accounts().unwrap(),
-        vec!["0x3fc74504d2b491d73079975e302279540bf6e44e".into(), "0x41178717678e402bdb663d98fe47669d93b29603".into()]
-    );
+    assert_eq!(store.accounts().unwrap(), vec![
+        "0x3fc74504d2b491d73079975e302279540bf6e44e".into(),
+        "0x41178717678e402bdb663d98fe47669d93b29603".into()
+    ]);
 }
 
 #[test]
@@ -128,10 +128,10 @@ fn decrypting_files_with_short_ciphertext() {
     let dir = RootDiskDirectory::at(ciphertext_path());
     let store = KeyStore::open(Box::new(dir)).unwrap();
     let accounts = store.accounts().unwrap();
-    assert_eq!(
-        accounts,
-        vec!["0x77a477c745390977a72f44437ac1dac19b705571".into(), "0x8267cb8df20e1dc57fef31322e16bddd83d4cc3d".into()]
-    );
+    assert_eq!(accounts, vec![
+        "0x77a477c745390977a72f44437ac1dac19b705571".into(),
+        "0x8267cb8df20e1dc57fef31322e16bddd83d4cc3d".into()
+    ]);
 
     let message = Default::default();
 

rustfmt.toml

@@ -49,7 +49,7 @@ use_try_shorthand = true # false
 # format_doc_comments = false
 wrap_comments = false
 match_arm_blocks = true
-overflow_delimited_expr = false
+overflow_delimited_expr = true
 blank_lines_upper_bound = 2 # 1
 blank_lines_lower_bound = 0
 # required_version

state/src/impls/top_level.rs

@@ -2470,10 +2470,9 @@ mod tests_tx {
         let asset_type = H160::zero();
         let transfer = transfer_asset!(
             inputs:
-                asset_transfer_inputs![(
-                    asset_out_point!(H256::random(), 0, asset_type, shard_id, 30),
-                    vec![0x30, 0x01]
-                )],
+                asset_transfer_inputs![(asset_out_point!(H256::random(), 0, asset_type, shard_id, 30), vec![
+                    0x30, 0x01
+                ])],
             asset_transfer_outputs![
                 (H160::random(), vec![vec![1]], asset_type, shard_id, 10),
                 (H160::random(), vec![], asset_type, shard_id, 5),

types/src/transaction/shard.rs

@@ -920,16 +920,13 @@ mod tests {
     fn fail_if_output_has_more_asset() {
         let asset_type = H160::random();
         let output_quantity = 100;
-        assert!(!is_input_and_output_consistent(
-            &[],
-            &[AssetTransferOutput {
-                lock_script_hash: H160::random(),
-                parameters: vec![],
-                asset_type,
-                shard_id: 0,
-                quantity: output_quantity,
-            }]
-        ));
+        assert!(!is_input_and_output_consistent(&[], &[AssetTransferOutput {
+            lock_script_hash: H160::random(),
+            parameters: vec![],
+            asset_type,
+            shard_id: 0,
+            quantity: output_quantity,
+        }]));
     }
 
     #[test]