Throw an error when unreachable code is reached

Author: kseo

src/command/create.ts

@@ -3,6 +3,7 @@ import { H256 } from "codechain-sdk/lib/core/classes";
 import { blake256, getAccountIdFromPublic } from "codechain-sdk/lib/utils";
 import * as _ from "lodash";
 
+import { CLIError, CLIErrorType } from "../error";
 import { AccountType } from "../types";
 import { getAddressFromPublic } from "../util";
 
@@ -14,13 +15,17 @@ export async function createKey(
     const publicKey = await cckey[accountType].createKey({
         passphrase
     });
-    if (accountType === "platform") {
-        const accountId = getAccountIdFromPublic(publicKey);
-        cckey.mapping.add({ key: accountId, value: publicKey });
-    }
-    if (accountType === "asset") {
-        const hash = H256.ensure(blake256(publicKey)).value;
-        cckey.mapping.add({ key: hash, value: publicKey });
+    switch (accountType) {
+        case "platform":
+            const accountId = getAccountIdFromPublic(publicKey);
+            cckey.mapping.add({ key: accountId, value: publicKey });
+            break;
+        case "asset":
+            const hash = H256.ensure(blake256(publicKey)).value;
+            cckey.mapping.add({ key: hash, value: publicKey });
+            break;
+        default:
+            throw new CLIError(CLIErrorType.Unreachable);
     }
 
     console.log(getAddressFromPublic(accountType, publicKey));

src/command/import.ts

@@ -4,6 +4,7 @@ import { H256 } from "codechain-sdk/lib/core/classes";
 import { blake256, getAccountIdFromPublic } from "codechain-sdk/lib/utils";
 import * as _ from "lodash";
 
+import { CLIError, CLIErrorType } from "../error";
 import { AccountType } from "../types";
 import { getAddressFromPublic } from "../util";
 
@@ -17,13 +18,17 @@ export async function importKey(
         secret,
         passphrase
     });
-    if (accountType === "platform") {
-        const accountId = getAccountIdFromPublic(publicKey);
-        cckey.mapping.add({ key: accountId, value: publicKey });
-    }
-    if (accountType === "asset") {
-        const hash = H256.ensure(blake256(publicKey)).value;
-        cckey.mapping.add({ key: hash, value: publicKey });
+    switch (accountType) {
+        case "platform":
+            const accountId = getAccountIdFromPublic(publicKey);
+            cckey.mapping.add({ key: accountId, value: publicKey });
+            break;
+        case "asset":
+            const hash = H256.ensure(blake256(publicKey)).value;
+            cckey.mapping.add({ key: hash, value: publicKey });
+            break;
+        default:
+            throw new CLIError(CLIErrorType.Unreachable);
     }
 
     console.log(getAddressFromPublic(accountType, publicKey));

src/error.ts

@@ -5,6 +5,7 @@ export enum CLIErrorType {
     InvalidAction,
     OptionRequired,
     NoSuchAddress,
+    Unreachable,
     Unknown
 }
 
@@ -26,6 +27,8 @@ function getErrorMessage(type: CLIErrorType, args: any = {}) {
             return `Option --${args.optionName} is required`;
         case CLIErrorType.NoSuchAddress:
             return `${args.address} is not found`;
+        case CLIErrorType.Unreachable:
+            return "Unreachable code reached";
         case CLIErrorType.Unknown:
             return `Internal error ${args.message}`;
         default: