Skip to content

Commit 2d3a5da

Browse files
joojismajecty
authored andcommitted
Do not await a request for the asset's icon_url
1 parent abd1560 commit 2d3a5da

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/models/logic/assetscheme.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ export async function createAssetScheme(
5252
//
5353
}
5454
if (metadataObj && metadataObj.icon_url) {
55-
await AssetImageModel.createAssetImage(
55+
// NOTE: No await here because the URL might be unreachable or slow
56+
AssetImageModel.createAssetImage(
5657
transactionHash,
5758
assetType,
58-
metadataObj.icon_url,
59-
options
59+
metadataObj.icon_url
6060
);
6161
}
6262
} catch (err) {

src/models/logic/changeAssetScheme.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,11 @@ export async function createChangeAssetScheme(
5151
// The metadata can be non-JSON.
5252
}
5353
if (metadataObj && metadataObj.icon_url) {
54-
await AssetImageModel.createAssetImage(
54+
// NOTE: No await here because the URL might be unreachable or slow
55+
AssetImageModel.createAssetImage(
5556
transactionHash,
5657
strip0xPrefix(assetType),
57-
metadataObj.icon_url,
58-
options
58+
metadataObj.icon_url
5959
);
6060
}
6161
await createAssetTypeLog(transaction, assetType, options);

0 commit comments

Comments
 (0)