Skip to content

Commit 75a219f

Browse files
author
Ma,Yutao
committed
refactor code
1 parent b81a9ed commit 75a219f

File tree

2 files changed

+9
-28
lines changed

2 files changed

+9
-28
lines changed

ingestion/src/metadata/ingestion/source/database/common_db_source.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -229,14 +229,6 @@ def yield_database(
229229
if len(database_owner_names) == 1
230230
else database_owner_names
231231
)
232-
# 🔍 DEBUG: Verify what we're storing
233-
import sys
234-
235-
print(
236-
f"🔍 [STORE_DB] database={database_name}, owner_names={database_owner_names}, storing={database_owner}, type={type(database_owner)}",
237-
file=sys.stderr,
238-
)
239-
240232
self.context.get().upsert("database_owner", database_owner)
241233
else:
242234
# Clear context to avoid residual owner from previous database

ingestion/tests/unit/metadata/ingestion/owner_config_tests/QUICK-START.md

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -154,16 +154,15 @@ source env/bin/activate
154154

155155
### Install Dependencies
156156

157-
If `metadata` command is not found:
158-
159157
```bash
158+
cd ~/path/to/OpenMetadata
159+
make install-dev
160+
make generate
161+
160162
cd ~/workspace/OpenMetadata/ingestion
161163

162164
# Install OpenMetadata ingestion package
163-
pip install -e .
164-
165-
# Or install with specific connectors
166-
pip install -e '.[postgres]'
165+
pip install -e . --force-reinstall --no-deps
167166
```
168167
---
169168

@@ -183,13 +182,6 @@ metadata ingest -c ingestion/tests/unit/metadata/ingestion/owner_config_tests/te
183182
- ✅ Should complete without errors
184183
- ✅ Child entities inherit parent owner (NOT default owner)
185184
- ✅ Check OpenMetadata UI: `finance_db.accounting.revenue` should have owner "finance-team"
186-
187-
**Run with verbose logging** (for debugging):
188-
```bash
189-
# From OpenMetadata root directory
190-
metadata ingest -c ingestion/tests/unit/metadata/ingestion/owner_config_tests/test-05-inheritance-enabled.yaml --log-level DEBUG
191-
```
192-
193185
---
194186

195187
### Run All Tests (Using Script)
@@ -236,15 +228,12 @@ Failed: 0
236228
**Test Files (in order):**
237229
1. test-01-basic-owner-config.yaml - Basic configuration
238230
2. test-02-fqn-matching.yaml - FQN matching
239-
3. test-03-multiple-users.yaml - Multiple users
240-
4. test-04-validation-errors.yaml - Validation errors
241-
5. test-05-inheritance-enabled.yaml - Inheritance enabled
242-
6. test-06-inheritance-disabled.yaml - Inheritance disabled
231+
3. test-03-multiple-users.yaml - Multiple users
232+
4. test-04-validation-errors.yaml - Validation errors
233+
5. test-05-inheritance-enabled.yaml - Inheritance enabled
234+
6. test-06-inheritance-disabled.yaml - Inheritance disabled
243235
7. test-07-partial-success.yaml - Partial success
244236
8. test-08-integration-test.yaml - Integration test
245-
246-
**Critical tests** (⭐) verify the two main bug fixes.
247-
248237
---
249238

250239
## Step 7: Verify Results

0 commit comments

Comments
 (0)